Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #155

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Various fixes #155

wants to merge 21 commits into from

Conversation

ziima
Copy link

@ziima ziima commented Dec 29, 2012

Fix several bugs:

  • Set cache state properly (especially disabled)
  • Prevent TypeError when simulating GPS.
  • Prevent ImportError when using hildon GUI.
  • Prevent connection errors when connecting to geocaching.com using bugged versions of OpenSSL.

danielfett and others added 20 commits September 8, 2012 11:59
@danielfett
Move fieldnote types to centralized place
9e3435e
@danielfett
Move log types to centralized place
0b6d59c
@danielfett
Introduce fieldnote and log uploading on the command line
a35fe20
@danielfett
Add default fieldnote text to QML gui
4f3e70a
@danielfett
Remove useless lambda function
ad7f010
@danielfett
Prepare everything for GUI changes that enable users to create and up…
e4ab95b 
…load fieldnotes and logs at the same time. Working with CLI.
@danielfett
N9 users can switch between log and fieldnote for every cache. Fieldn…
9957e29 
…ote-Buttons are renamed to Fieldnote/Log-Buttons.
@danielfett
Black font color in QML Fieldnote info dialog changed to white.
aaafc1c
@danielfett
Pull in changes from 0.9.1.2
2ff6d04
@danielfett
Log uploading shows the correct number of the currently uploading log
707331f
@danielfett
Fieldnote help text is readable under both themes
b74fc42
@danielfett
Merge from branch master
8a283e3
@danielfett
Fix several bugs
b7a18c0
@danielfett
Some cleanup work
b1e813f
@danielfett
Fix merge
af036cd
@ziima
Fixes in download and core.
e094063 
 * Update status when downloading overview.
 * Refactor status resolving when downloading details.
 * Prevent `TypeError` when simulating GPS.
 * Remove useless whitespaces from `cachedownloader`.
@ziima
Avoid openssl bug which prevent SSL connection to geocaching.com
ace5ebd
@ziima
Return missing import
372f096
@ziima
Ignore parsing errors in cache details download
d04a490 
 * Prevent loss of data when error in parsing is encountered.
@ziima
Refactor cache types; fixes
516967e 
 * Move cache types to constants, add missing common cache types.
 * Refactor imports in several modules - use explicit agtl namespace to avoid conflicts.
 * Clean cache type parsing - reduce duplicity.
 * Fix download of overview over multiple pages.
@ziima
Copy link
Author

ziima commented Dec 29, 2012

I have added two other commits.

First one continues with download if there is error in cache page parsing.
Second adds and refactors cache types. It also contains some additional refactoring which should be finished.

@ziima
Copy link
Author

ziima commented Dec 30, 2012

Cleaned up the rest of imports. It caused some import bug on N900.

@danielfett
Copy link
Owner

After all these comments on single commits or lines, I'd first like to thank you for the patches. I will try to use as much as possible. However, it would be easier if the refactoring things would be separated from the changes in functionality.

@ziima
Copy link
Author

ziima commented Jan 2, 2013

Ad 1) The download of overview is quite a big method and bit confusing, it should be worth splitting it into several ones. If you think that these flags are the same or similar enough, we should merge them.
Ad 2) That is bad :( But the parsing of date format is preference dependent as well, is it not? I checked the HTML, but I did not found no way to differentiate between disabled and archived. Only language-independent way to resolve this from cache page is to download all (!) the logs.
Ad 3) I applied this patch to my N900 and it looks good so far :)
Ad 4) I my experience, using namespace is fairly common in well behaved python 2 libraries. You might encounter serious problems when you do not differentiate between your imports and import from other libraries. Especially for common names like utils and gui. You might also run into troubles with modules copied from other sources, like threadpool and pyfo. You can check the projects I poked my nose in :)
It would be also nice to add a shell script(s) that starts AGTL, so sys.path is not changed on the run. But I did not know how you will react to my refactoring, so I did not do it.
Ad 5) Yes, I am sorry for that. At first I just wanted to fix the bugs I found, but I fell into it.

@ziima
Copy link
Author

ziima commented Jan 2, 2013

I do not see an changes in devel branch, have you pushed it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ziima @danielfett