GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fix several bugs:
Move fieldnote types to centralized place
Move log types to centralized place
Introduce fieldnote and log uploading on the command line
Add default fieldnote text to QML gui
Remove useless lambda function
Prepare everything for GUI changes that enable users to create and up…
…load fieldnotes and logs at the same time. Working with CLI.
N9 users can switch between log and fieldnote for every cache. Fieldn…
…ote-Buttons are renamed to Fieldnote/Log-Buttons.
Black font color in QML Fieldnote info dialog changed to white.
Pull in changes from 0.9.1.2
Log uploading shows the correct number of the currently uploading log
Fieldnote help text is readable under both themes
Merge from branch master
Fix several bugs
Some cleanup work
Fixes in download and core.
* Update status when downloading overview.
* Refactor status resolving when downloading details.
* Prevent `TypeError` when simulating GPS.
* Remove useless whitespaces from `cachedownloader`.
Avoid openssl bug which prevent SSL connection to geocaching.com
Return missing import
Ignore parsing errors in cache details download
* Prevent loss of data when error in parsing is encountered.
Refactor cache types; fixes
* Move cache types to constants, add missing common cache types.
* Refactor imports in several modules - use explicit agtl namespace to avoid conflicts.
* Clean cache type parsing - reduce duplicity.
* Fix download of overview over multiple pages.
I have added two other commits.
First one continues with download if there is error in cache page parsing.
Second adds and refactors cache types. It also contains some additional refactoring which should be finished.
Refactor the rest of imports.
Cleaned up the rest of imports. It caused some import bug on N900.
After all these comments on single commits or lines, I'd first like to thank you for the patches. I will try to use as much as possible. However, it would be easier if the refactoring things would be separated from the changes in functionality.
Ad 1) The download of overview is quite a big method and bit confusing, it should be worth splitting it into several ones. If you think that these flags are the same or similar enough, we should merge them.
Ad 2) That is bad :( But the parsing of date format is preference dependent as well, is it not? I checked the HTML, but I did not found no way to differentiate between disabled and archived. Only language-independent way to resolve this from cache page is to download all (!) the logs.
Ad 3) I applied this patch to my N900 and it looks good so far :)
Ad 4) I my experience, using namespace is fairly common in well behaved python 2 libraries. You might encounter serious problems when you do not differentiate between your imports and import from other libraries. Especially for common names like utils and gui. You might also run into troubles with modules copied from other sources, like threadpool and pyfo. You can check the projects I poked my nose in :)
It would be also nice to add a shell script(s) that starts AGTL, so sys.path is not changed on the run. But I did not know how you will react to my refactoring, so I did not do it.
Ad 5) Yes, I am sorry for that. At first I just wanted to fix the bugs I found, but I fell into it.
I do not see an changes in devel branch, have you pushed it?