Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension-browser] Refactor devtools panel to not call sendMessage directly #2181

Open
antross opened this issue Apr 5, 2019 · 0 comments

Comments

@antross
Copy link
Member

antross commented Apr 5, 2019

I've been debating refactoring this a bit to have a single utils file with methods to call for each action that sends messages (and only have that file actually call sendMessage).

Originally posted by @antross in #2140

This should help the code that triggers messages read better and provide a clear choke point if we need to change how messages are sent (e.g. if we move some analysis to a worker in the future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant