Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make hint-manifest-scoped-urls work with local connector #2360

Open
antross opened this issue May 2, 2019 · 0 comments
Open

[Feature] Make hint-manifest-scoped-urls work with local connector #2360

antross opened this issue May 2, 2019 · 0 comments

Comments

@antross
Copy link
Member

antross commented May 2, 2019

I agree with @molant we should change this to site scope for now and open a separate issue to think about how to best make this work with the local connector in the future.

    scope: HintScope.site

My primary concern for the local connector is that when used with the VS Code extension we can re-run on nearly every keypress. That's a lot of filesystem access due to the fetchContent calls here so we'd probably want to work out some sort of caching like we did for hint-sri in this context.

Originally posted by @antross in #2328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants