Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing node-zopfli doesn't currently work [1] #448

Closed
alrra opened this issue May 28, 2018 · 2 comments · Fixed by #585
Closed

Installing node-zopfli doesn't currently work [1] #448

alrra opened this issue May 28, 2018 · 2 comments · Fixed by #585
Assignees
@molant
Labels
type:bug
Milestone
1812-1

Comments

@alrra
Copy link
Contributor

alrra commented May 28, 2018 •
edited

I've switch to node LTS on Travis CI so that we can at least build it (that also fails on latest node).

Ref: pierreinglebert/node-zopfli#93
@alrra alrra added the type:bug label May 28, 2018
alrra added a commit that referenced this issue May 28, 2018
@alrra
Build: Make Travis CI use Node LTS
651c52e 
This change is done in order to be able to build `node-zopfli`.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Ref: #448
See also: pierreinglebert/node-zopfli#93
alrra added a commit that referenced this issue May 29, 2018
@alrra
Build: Make Travis CI use Node LTS
df6c66b 
This change is done in order to be able to build `node-zopfli`.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Ref: #448
See also: pierreinglebert/node-zopfli#93
alrra added a commit that referenced this issue May 29, 2018
@alrra
Build: Make Travis CI use Node LTS
25dfa22 
This change is done in order to be able to build `node-zopfli`.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Ref: #448
See also: pierreinglebert/node-zopfli#93
alrra added a commit that referenced this issue May 29, 2018
@alrra
Build: Make Travis CI use Node LTS
ea0e8b0 
This change is done in order to be able to build `node-zopfli`.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Ref: #448
See also: pierreinglebert/node-zopfli#93
alrra added a commit that referenced this issue May 29, 2018
@alrra
Build: Make Travis CI use Node LTS
3a673ad 
This change is done in order to be able to build `node-zopfli`.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Ref: #448
See also: pierreinglebert/node-zopfli#93
@Nexuist Nexuist mentioned this issue Oct 8, 2018
Closed
2 tasks
@molant
Copy link
Member

molant commented Oct 19, 2018

Doesn't look like the package is going to be updated any time soon. I see a couple of alternatives:

Thoughts @webhintio/core?

molant added a commit to molant/webhint.io that referenced this issue Dec 7, 2018
@molant
Fix: Issues with node-zopfli
d8f552e 
Change dependency to `gulp-zopfli-node` so pre-compiled binaries are
downloaded.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#448
molant added a commit to molant/webhint.io that referenced this issue Dec 7, 2018
@molant
Fix: Issues with node-zopfli
e69fb73 
Change dependency to `gulp-zopfli-node` so pre-compiled binaries are
downloaded.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#448
molant added a commit to molant/webhint.io that referenced this issue Dec 7, 2018
@molant
Fix: Issues with node-zopfli
9b7b571 
Change dependency to `gulp-zopfli-node` so pre-compiled binaries are
downloaded.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#448
@molant molant mentioned this issue Dec 7, 2018
Merged
2 tasks
@molant molant self-assigned this Dec 7, 2018
@molant molant added this to the 1812-1 milestone Dec 7, 2018
@molant molant changed the title Installing node-zopfli doesn't currently work Installing node-zopfli doesn't currently work [0.5] Dec 7, 2018
@molant
Copy link
Member

molant commented Dec 7, 2018

There's a PR for this now

molant added a commit to molant/webhint.io that referenced this issue Dec 7, 2018
@molant
Fix: Issues with node-zopfli
7d6eb80 
Change dependency to `gulp-zopfli-node` so pre-compiled binaries are
downloaded.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#448
molant added a commit to molant/webhint.io that referenced this issue Dec 7, 2018
@molant
Fix: Issues with node-zopfli
19c7923 
Change dependency to `gulp-zopfli-node` so pre-compiled binaries are
downloaded.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#448
molant added a commit to molant/webhint.io that referenced this issue Dec 7, 2018
@molant
Fix: Issues with node-zopfli
62c8ba5 
Change dependency to `gulp-zopfli-node` so pre-compiled binaries are
downloaded.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#448
molant added a commit to molant/webhint.io that referenced this issue Dec 7, 2018
@molant
Fix: Issues with node-zopfli
4381dad 
Change dependency to `gulp-zopfli-node` so pre-compiled binaries are
downloaded.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#448
molant added a commit to molant/webhint.io that referenced this issue Dec 7, 2018
@molant
Fix: Issues with node-zopfli
b5abea6 
Change dependency to `gulp-zopfli-node` so pre-compiled binaries are
downloaded.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#448
@molant molant changed the title Installing node-zopfli doesn't currently work [0.5] Installing node-zopfli doesn't currently work [1] Dec 7, 2018
molant added a commit that referenced this issue Dec 9, 2018
@molant
Fix: Issues with node-zopfli (#585)
ed3a4f2 
Change dependency to `gulp-zopfli-node` so pre-compiled binaries are
downloaded.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@molant molant

Labels
type:bug
Projects
None yet
Milestone
1812-1
Development

Successfully merging a pull request may close this issue.

Fix: Issues with node-zopfli molant/webhint.io
2 participants
@molant @alrra