Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting width of grid in Page Builder affects child cells, too. #1412

Closed
jimjoes opened this issue Feb 3, 2021 · 8 comments · Fixed by #2007
Closed

Setting width of grid in Page Builder affects child cells, too. #1412

jimjoes opened this issue Feb 3, 2021 · 8 comments · Fixed by #2007
Assignees

Comments

@jimjoes
Copy link
Contributor

jimjoes commented Feb 3, 2021

This is:

  • Bug

Specifications

  • version: 5.beta.4
  • OS: MacOs
  • Browser: Chrome 88.0.4324.96

Actual Behavior

Setting the width of a grid to 50% makes the width of a child cell also 50% (i.e. the cell becomes 25%, rather than just 50% (minus a little)).

Expected Behavior

Setting the width of a grid to 50% shouldn't directly affect the width % of its children.

Steps to Reproduce the Problem

  1. Create page
  2. Create block
  3. Create grid
  4. Set grid to 50%.
  5. The cell also gets set to 50%.

Detailed Description

Possible Solution

@jimjoes jimjoes changed the title Setting width of grid in Page Builder makes affects cells, too. Setting width of grid in Page Builder affects child cells, too. Feb 3, 2021
@webiny-bot
Copy link
Collaborator

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@webiny-bot webiny-bot added the stale-issue This label is automatically assigned to issues that have no activity for at least 60 days. label Apr 7, 2021
@jimjoes
Copy link
Contributor Author

jimjoes commented Apr 15, 2021

This is still a problem in 5.4.0.

@Pavel910
Copy link
Collaborator

@econtentmaps thanks for the bump. Need to reconfigure the stale bot... Reopening this.

@Pavel910 Pavel910 reopened this Apr 15, 2021
@Pavel910 Pavel910 removed the stale-issue This label is automatically assigned to issues that have no activity for at least 60 days. label Apr 15, 2021
@Ashu96
Copy link
Contributor

Ashu96 commented Apr 15, 2021

@econtentmaps Can you please provide some screenshots? It will help in reproducing the bug.
Thanks 👍

@webiny-bot
Copy link
Collaborator

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@webiny-bot webiny-bot added the stale-issue This label is automatically assigned to issues that have no activity for at least 60 days. label Jun 15, 2021
@jimjoes
Copy link
Contributor Author

jimjoes commented Sep 28, 2021

Hi. Sorry. Missed the screenshot request.

It's pretty simple. create a grid. add an element to it. Set the grid to 50% width. The grid is 50%, but its contents are also 50% of the grid's width - they should remain at 100% of the grid, regardless of the grid's width.

image

@Pavel910 Pavel910 removed the stale-issue This label is automatically assigned to issues that have no activity for at least 60 days. label Sep 28, 2021
@Pavel910 Pavel910 reopened this Sep 28, 2021
@Pavel910
Copy link
Collaborator

@econtentmaps thanks, screenshots help a lot. Keep in mind that we work on dozens of completely unrelated features every week and context switching is difficult if not enough information is provided in the issue. A screenshot tells a thousand words.

This makes sense, we'll keep track of this and see when we can squeeze this in our product cycles. 🍻

@jimjoes
Copy link
Contributor Author

jimjoes commented Sep 29, 2021

Yea - I raised this when 5 came out and I did a load of testing but I omitted the screenshots in many cases. Sorry :)

@sync-by-unito sync-by-unito bot changed the title Setting width of grid in Page Builder affects child cells, too. WEB-241 ⁃ Setting width of grid in Page Builder affects child cells, too. Oct 20, 2021
@plsalvado plsalvado changed the title WEB-241 ⁃ Setting width of grid in Page Builder affects child cells, too. Setting width of grid in Page Builder affects child cells, too. Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants