Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ACO table rendering performances #3439

Merged
merged 21 commits into from
Jul 28, 2023
Merged

fix: ACO table rendering performances #3439

merged 21 commits into from
Jul 28, 2023

Conversation

leopuleo
Copy link
Contributor

Changes

With this PR we aim to solve some table rendering performances issues by:

  • memoizing table column definition
  • memoizing Table rows and cells components
  • removing some out-of-date methods in useAcoList
  • removing <DialogMove /> in favour of useMoveToFolderDialog hook: this has already been implemented inside app-file-manager - this has already been planned with this PR.

How Has This Been Tested?

Manually

In the table below, we compare the times to load the records and render the table at each pagination.

1° 2° 3° 4° 5° 6° 7° 8° 9° 10°
Old 3013 2952 3493 3902 4361 5129 5493 6117 6977 7413
New 2060 2467 2457 2333 2481 2697 3321 3106 3361 3698

@leopuleo
feat: add useMovePageToFolder hook
503e87d
@leopuleo
refactor: add internal values to table entries
b868670
@leopuleo
refactor: add useMoveContentEntryToFolder
bf4447f
@leopuleo
refactor: remove DialogMove standalone component
fb3a253
@leopuleo
fix: close dialog in case of errors
3f2e768
@leopuleo
fix: pass record id to moveRecord
310261c
@leopuleo
chore: simplify useMovePageToFolder hook params
986ce6b
@leopuleo
Merge branch 'next' into leo/refactor/use-move-to-folder-dialog
79f3abb
@leopuleo
fix: revision type
54820f7
@leopuleo
fix: location interface in app-headless-cms-common
3e1eebe
@leopuleo
Merge branch 'next' into leo/refactor/use-move-to-folder-dialog
a14d858
@leopuleo
fix: reset "after" on sort update
8f48b4e
@leopuleo
fix: improve data fetching and merging performance
cfda9d4
@leopuleo
fix: memoize table cells
f513c86
@leopuleo
Merge branch 'leo/refactor/use-move-to-folder-dialog' into leo/fix/va…
2db633c 
…rious-aco

# Conflicts:
#	packages/app-headless-cms/src/admin/components/ContentEntries/Table/index.tsx
@leopuleo
chore: merge
6645690
@leopuleo
fix: useMemo for column definition
f04037d
@leopuleo
feat: memoize cells and rows
5e86666
@leopuleo
chore: remove console.log
4bb2b71
@leopuleo
fix: return null if not loading
3ce6675
@leopuleo leopuleo added the aco label Jul 25, 2023
@leopuleo leopuleo added this to the 5.37.1 milestone Jul 25, 2023
@leopuleo leopuleo requested a review from brunozoric July 25, 2023 14:14
@leopuleo leopuleo self-assigned this Jul 25, 2023
brunozoric
brunozoric previously approved these changes Jul 28, 2023
View reviewed changes
@leopuleo leopuleo changed the base branch from next to dev July 28, 2023 09:07
@leopuleo leopuleo dismissed brunozoric’s stale review July 28, 2023 09:07

The base branch was changed.

@leopuleo leopuleo merged commit 09b3f5b into dev Jul 28, 2023
58 checks passed
@leopuleo leopuleo mentioned this pull request Jul 28, 2023
Closed
@leopuleo leopuleo deleted the leo/fix/various-aco branch August 23, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunozoric brunozoric brunozoric approved these changes

Assignees

@leopuleo leopuleo

Labels
aco
Projects
None yet
Milestone
5.37.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leopuleo @brunozoric