-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add audit logs #3454
feat: add audit logs #3454
Conversation
a47fd68
to
4df5051
Compare
@brunozoric Please let me know if you have any question. |
I did an initial test run of the implementation and I've noticed we're missing the security events in the audit logs (login successful, login unsuccessful, ...). |
@SvenAlHamad |
@SvenAlHamad |
87c297f
to
91440af
Compare
1032239
to
b03979e
Compare
@neatbyte-vnobis There are no tests for Audit Logs in this branch. Do you have them somewhere else? |
Currently I've only added tests for new lifecycle events in some API packages (like this). Tests for
|
When having a record with a lot of content (eg, page larger than 400KB), audit logs are not stored. |
When APW is on and there is a CMS workflow, something is wrong when trying to request review on publish. It is working in next branch, so it's probably something you added in the Audit Logs. |
When trying to search for something in Audit Log Payload JSON box (using the CMD+F on Mac, probably CTRL+F on Windows), error is thrown. |
When creating or updating the API Key, do not store the token into the payload data - filter it out. |
I agree that compression needs to be done. Have a couple questions:
|
29c7243
to
b03979e
Compare
b03979e
to
4bf4225
Compare
8f964c0
to
4bd7d59
Compare
11b6859
to
43fdafb
Compare
Changes
Implements issue "Audit Logs".
Added new "Audit Logs" item in left side menu:
Audit Logs table:
Changes by package:
This package currently serves as API for audit logs. Most of the logic is copied from
api-page-builder-aco
package.This package contains all subscriptions for lifecycle events under
/src/subscriptions
. There is also a config file under/src/config
, where all possible audit logapps
,events
,actions
defined.Added lifecycle events for file manager settings update. Also added test for new lifecycle events.
Added lifecycle events for form submissions export.
Added lifecycle events for import and export.
Added lifecycle events for
ApiKeys
,Groups
andTeams
. Also added tests for new lifecycle events (exceptTeams
since there were no tests for them at all).Audit logs UI (table, filters, modal, etc.)
Fixed wrong gql input data type for UpdateFileManagerSettings mutation. It was causing error when updating file manager settings.
Added audit logs to main app.
Copy of apps/api changes.
Added
readOnly
property toCodeEditor
component and JSON mode for audit logs payload JSON preview.How Has This Been Tested?
Manual
Documentation
None