feat: modify elasticsearch index creation #3466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cypress |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
…modify creation if necessary
brunozoric
force-pushed
the
bruno/feat/elasticsearch/index-creation
branch
from
62c6f7f
to
bcb0dd0
Compare
adrians5j
pushed a commit
to Asmaloth/webiny-js
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes index creation and the way it checks for existing index before creating it. This way we will have a single method, which we can modify if necessary, to properly create the indexes (without failures).
It also:
How Has This Been Tested?
Jest and manually.