feat: add bulk actions to HCMS #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavel910
requested changes
Sep 11, 2023
| @@ -34,7 +36,7 @@ export const Buttons: React.VFC<ButtonsProps> = props => { | |||
| return ( | |||
| <> | |||
| {props.actions.map(action => ( | |||
| <ButtonContainer key={action.name}> | |||
| <ButtonContainer key={action.name} className={"button-container"}> | |||
There was a problem hiding this comment.
Adding CSS classes randomly is a bad idea. It's better to either add props to the component, or simply create a component variant, like <NoMarginButtonContainer>, and you can even keep it local to this view.
const NoMarginButtonContainer = styled(ButtonContainer)`
margin: 0;
`;There was a problem hiding this comment.
Here is the problem: We are using the same component to render Entry Editor Actions and now the Entry List Bulk actions.
I don't like to use the CSS class but I need to target the single action from different parts of the UI.
I changed it: now I'm exporting the styled component from the @webiny/app-admin package so I can target it inside the specific component.
packages/app-headless-cms/src/admin/components/ContentEntries/BulkActions/styles.tsx
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/app-headless-cms/src/admin/components/ContentEntries/Table/index.tsx
Pavel910
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, we allow bulk actions to headless CMS entries. The default bulk actions are:
Third-party developers can add bulk actions: a new article describing the process will be added to the developer docs.
How Has This Been Tested?
Jest + manually
Documentation
Inline + Developer Doc article (TBD)