fix: fix form fields options editing #3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neatbyte-vnobis
force-pushed
the
neatbyte/fields-with-options-fix
branch
from
1749188
to
f1e0aa7
Compare
adrians5j
requested changes
Sep 21, 2023
| @@ -163,7 +163,7 @@ const OptionsList: React.FC<OptionsListProps> = ({ form, multiple, otherOption } | |||
| setOptionsValue(newValue); | |||
| clearEditOption(); | |||
| }, | |||
| [optionsValue, setOptionsValue] | |||
| [optionsValue, editOption, setOptionsValue] | |||
There was a problem hiding this comment.
You know what... Let's loose the whole useCallback wrapper. I'm surprised this even works: a useCallback called in the Bind component's children renderer prop. Sheesh 😰
adrians5j
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolve issue "Incorrect option changes on dropdown/checkbox/radio field edit".
Task provided by @SvenAlHamad no reference to issue or Notion.
There was missed
useCallbackdependency that cause updating of wrong field option insideForm Editor.How Has This Been Tested?
Manual
Documentation
None