-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-headless-cms): skip required validator on create, update and create revision #3583
Merged
brunozoric
merged 14 commits into
bruno/feat/headless-cms/optional-entry-validation
from
bruno/feat/app-headless-cms/skip-validators
Oct 19, 2023
Merged
feat(app-headless-cms): skip required validator on create, update and create revision #3583
brunozoric
merged 14 commits into
bruno/feat/headless-cms/optional-entry-validation
from
bruno/feat/app-headless-cms/skip-validators
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cypress |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
brunozoric
changed the base branch from
bruno/feat/api-headless-cms/skip-validators
to
bruno/feat/headless-cms/optional-entry-validation
October 11, 2023 10:15
… bruno/feat/app-headless-cms/skip-validators
brunozoric
merged commit Oct 19, 2023
2494c46
into
bruno/feat/headless-cms/optional-entry-validation
57 checks passed
adrians5j
pushed a commit
to Asmaloth/webiny-js
that referenced
this pull request
Oct 23, 2023
… create revision (webiny#3583)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR makes it possible to store a partial CMS entry by skipping the required validator.
The required validator is not executed on create, createFrom and update mutations. On publish mutation, validator is executed normally.
If a field is populated, then other attached validators kick in.
How Has This Been Tested?
Manually.