Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-headless-cms): skip required validator on create, update and create revision #3583

Conversation

brunozoric
Copy link
Contributor

@brunozoric brunozoric commented Oct 9, 2023

Changes

This PR makes it possible to store a partial CMS entry by skipping the required validator.

The required validator is not executed on create, createFrom and update mutations. On publish mutation, validator is executed normally.
If a field is populated, then other attached validators kick in.

How Has This Been Tested?

Manually.

@brunozoric brunozoric self-assigned this Oct 9, 2023
@brunozoric brunozoric added this to the 5.38.0 milestone Oct 9, 2023
@brunozoric brunozoric added the cms label Oct 9, 2023
@brunozoric brunozoric marked this pull request as ready for review October 10, 2023 09:13
@brunozoric
Copy link
Contributor Author

/cypress

@github-actions
Copy link

Cypress E2E tests have been initiated (for more information, click here). ✨

@brunozoric brunozoric changed the base branch from bruno/feat/api-headless-cms/skip-validators to bruno/feat/headless-cms/optional-entry-validation October 11, 2023 10:15
@brunozoric brunozoric merged commit 2494c46 into bruno/feat/headless-cms/optional-entry-validation Oct 19, 2023
57 checks passed
brunozoric added a commit that referenced this pull request Oct 19, 2023
brunozoric added a commit that referenced this pull request Oct 20, 2023
brunozoric added a commit that referenced this pull request Oct 20, 2023
brunozoric added a commit that referenced this pull request Oct 23, 2023
adrians5j pushed a commit to Asmaloth/webiny-js that referenced this pull request Oct 23, 2023
@brunozoric brunozoric deleted the bruno/feat/app-headless-cms/skip-validators branch November 15, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant