Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lexical-editor): update editor state via UpdateStatePlugin #3650

Merged
merged 3 commits into from
Nov 1, 2023
Merged

fix(lexical-editor): update editor state via UpdateStatePlugin #3650

merged 3 commits into from
Nov 1, 2023

Conversation

Pavel910
Copy link
Collaborator

Changes

This PR fixes 2 Lexical issues:

  1. ensures errors thrown by Lexical do not break the app.
  2. ensures state updates are always performed via a plugin, and not through the initial editor config.

How Has This Been Tested?

Manually, in Headless CMS and Page Builder, using a custom plugin registered via the Admin app.

@Pavel910 Pavel910 added this to the 5.38.0 milestone Oct 30, 2023
@Pavel910 Pavel910 self-assigned this Oct 30, 2023
@Pavel910 Pavel910 merged commit 2eb310a into next Nov 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Pavel910 Pavel910

Labels
bug lexical-editor
Projects
None yet
Milestone
5.38.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Pavel910