Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-aco): flp entry decorator #3664

Merged
merged 6 commits into from
Nov 2, 2023
Merged

fix(api-aco): flp entry decorator #3664

merged 6 commits into from
Nov 2, 2023

Conversation

brunozoric
Copy link
Contributor

@brunozoric brunozoric commented Nov 1, 2023 •
edited

Changes

Fix for CMS Entry CRUD decorator:

  • not all variables are passed into the original method
  • move entry method not implemented
  • create entry revision method not implemented
  • listing entries with correct folder types

How Has This Been Tested?

Jest and manually.

@brunozoric brunozoric self-assigned this Nov 1, 2023
@brunozoric brunozoric added this to the 5.38.0 milestone Nov 1, 2023
@brunozoric brunozoric marked this pull request as ready for review November 1, 2023 19:16
@brunozoric brunozoric changed the title fix(api-aco): entry decorator not passing all required variables fix(api-aco): flp entry decorator Nov 2, 2023
adrians5j
adrians5j approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@adrians5j adrians5j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @brunozoric !

@brunozoric brunozoric merged commit 607b8af into next Nov 2, 2023
63 checks passed
@leopuleo leopuleo deleted the bruno/fix/api-aco/flp-entry-decorator branch November 6, 2023 06:44
@leopuleo leopuleo restored the bruno/fix/api-aco/flp-entry-decorator branch November 6, 2023 06:45
adrians5j pushed a commit that referenced this pull request Nov 8, 2023
@brunozoric @adrians5j
fix(api-aco): flp entry decorator (#3664)
d866e35
@brunozoric brunozoric deleted the bruno/fix/api-aco/flp-entry-decorator branch November 15, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leopuleo leopuleo leopuleo approved these changes

@Pavel910 Pavel910 Awaiting requested review from Pavel910

@adrians5j adrians5j Awaiting requested review from adrians5j

Assignees

@brunozoric brunozoric

Labels
api bug
Projects
None yet
Milestone
5.38.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brunozoric @leopuleo @adrians5j