Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-initialize filter repository on namespace change #3668

Merged
merged 6 commits into from
Nov 7, 2023
Merged

fix: re-initialize filter repository on namespace change #3668

merged 6 commits into from
Nov 7, 2023

Conversation

leopuleo
Copy link
Contributor

@leopuleo leopuleo commented Nov 3, 2023

Changes

We addressed an issue that occurred while navigating through various HCMS entry lists.

The issue was caused by the FilterRepository not being re-initialized upon a change in namespace.

To fix this, we implemented a check to determine if any new namespace or client was received and used useMemo to memoize the returned value.

How Has This Been Tested?

Jest

@leopuleo leopuleo added the aco label Nov 3, 2023
@leopuleo leopuleo added this to the 5.38.0 milestone Nov 3, 2023
@leopuleo leopuleo self-assigned this Nov 3, 2023
brunozoric
brunozoric approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@brunozoric brunozoric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Pavel910
Pavel910 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@Pavel910 Pavel910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Nothing to add here :)

@Pavel910 Pavel910 merged commit 142cd9a into next Nov 7, 2023
63 checks passed
adrians5j pushed a commit that referenced this pull request Nov 8, 2023
@leopuleo @adrians5j
fix(app-aco): re-initialize filter repository on namespace change (#3668
f78fb90 
)
@leopuleo leopuleo deleted the leo/fix/filter-repository-instance branch December 5, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavel910 Pavel910 Pavel910 approved these changes

@brunozoric brunozoric brunozoric approved these changes

Assignees

@leopuleo leopuleo

Labels
aco
Projects
None yet
Milestone
5.38.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leopuleo @Pavel910 @brunozoric