fix: advanced search filter boolean files #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunozoric
reviewed
Nov 9, 2023
| return false; | ||
| } | ||
|
|
||
| return value || ""; |
There was a problem hiding this comment.
If the value is false (boolean) you will get empty string as a result.
There was a problem hiding this comment.
Thanks @brunozoric, for pointing this out. I changed it into the nullish coalescing operator.
brunozoric
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR we fixed a bug encountered while trying to save a filter with a boolean field:
valueas a string - as expected byFilterDTObooleanwhen returned back viaGraphQLInputMapperHow to reproduce the bug
CleanShot.2023-11-09.at.13.05.49.mp4
How Has This Been Tested?
Jest + manually