New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to react 18 #3771

Merged

brunozoric merged 65 commits into next from bruno/feat/upgrade-to-react-18

May 3, 2024

Contributor

brunozoric commented Dec 13, 2023

Changes

Umbrella PR for React 18 upgrade.

How Has This Been Tested?

Jest, Cypress and manually.

Upgrade

User project will, probably, need to upgraded.

Documentation

Note that this is a breaking change and users will need to upgrade their projects.

brunozoric added the umbrella ☂️ label

brunozoric added this to the 5.40.0 milestone

brunozoric self-assigned this

brunozoric force-pushed the bruno/feat/upgrade-to-react-18 branch from f24a82a to 3cc8a45 Compare

December 14, 2023 15:18

brunozoric force-pushed the bruno/feat/upgrade-to-react-18 branch 2 times, most recently from 53b9f89 to 32493e1 Compare

January 12, 2024 13:22

neatbyte-ivelychko commented Jan 12, 2024

We are using react-sortable-hoc library in the app-form-builder, and we might have issues because of that.
Basically this library has not been supported for 2 years and it uses React v16 and because of that the build is red.
But I can see that developers of react-sortable-hoc have created new library dnd-kit. And they strongly recommend to use newer library.
So what should we do?

Знімок екрана 2024-01-12 о 16 19 23

brunozoric force-pushed the bruno/feat/upgrade-to-react-18 branch from 4733ed8 to 0df4f64 Compare

January 17, 2024 09:17

brunozoric force-pushed the bruno/feat/upgrade-to-react-18 branch from 6925c9a to 7a1af5c Compare

February 6, 2024 09:02

brunozoric requested review from Pavel910, leopuleo and adrians5j

February 6, 2024 09:05

Contributor Author

brunozoric commented Feb 6, 2024

/cypress

github-actions bot commented Feb 6, 2024

Cypress E2E tests have been initiated (for more information, click here). ✨

brunozoric force-pushed the bruno/feat/upgrade-to-react-18 branch from 7178a7b to 09b6a48 Compare

February 14, 2024 21:06

brunozoric force-pushed the bruno/feat/upgrade-to-react-18 branch from 5ba2634 to cc4c963 Compare

March 13, 2024 10:04

Contributor Author

brunozoric commented Mar 13, 2024

/cypress

github-actions bot commented Mar 13, 2024

Cypress E2E tests have been initiated (for more information, click here). ✨

brunozoric mentioned this pull request

React 18 Testing #4040

Open

9 tasks

brunozoric force-pushed the bruno/feat/upgrade-to-react-18 branch from 1c4b196 to 7283489 Compare

March 18, 2024 11:41

brunozoric force-pushed the bruno/feat/upgrade-to-react-18 branch from ec15080 to d3ceaeb Compare

March 28, 2024 11:55

Member

adrians5j commented Apr 8, 2024

/cypress

github-actions bot commented Apr 8, 2024

Cypress E2E tests have been initiated (for more information, click here). ✨

Member

adrians5j commented Apr 9, 2024

/cypress

github-actions bot commented Apr 9, 2024

Cypress E2E tests have been initiated (for more information, click here). ✨

1 similar comment

github-actions bot commented Apr 9, 2024

Cypress E2E tests have been initiated (for more information, click here). ✨

Member

adrians5j commented Apr 10, 2024

/cypress

github-actions bot commented Apr 10, 2024

Cypress E2E tests have been initiated (for more information, click here). ✨

Contributor

leopuleo commented Apr 24, 2024

/cypress

github-actions bot commented Apr 24, 2024

Cypress E2E tests have been initiated (for more information, click here). ✨

brunozoric and others added 21 commits

May 2, 2024 14:38


          fix(ui): memoize data table columns and data

c4d75e8


          fix(ui): data table continuous rendering

df34108


          feat: introduce useStateWithCallback hook

3a50174


          fix: properly open/close "create page template" dialog

922b144


          fix: redirect only when the state has been set

6a8feb3


          chore: run prettier

bcb8061


          fix: redirect only when the state has been set

cfde576


          fix: remove unneeded open flag

80ea667


          fix: use open prop instead of conditionally rendering the component

5d928bf


          fix: assign PagePreviewDimension type to dimensions param

f87e30e


          fix: remove "Successfully" word

3eeb21d


          fix: improve message

270b8f7


          fix: make graceful error messages more prominent

a0df3a2


          fix: add twoLine={true} prop

302ae01


          fix: ensure Chip/Chips components the same as before

b887942


          fix: update Checkbox and Typography usage

be0beef


          fix: ensure Chip/Chips components the same as before

eaa0041


          chore: add cy:setup

ea8046c


          fix: remove unneeded component

0e3e7fb


          fix: bring back the original design of the list

02b2283


          fix: after next merge

04e416d

brunozoric force-pushed the bruno/feat/upgrade-to-react-18 branch from 4f93a42 to 04e416d Compare

May 2, 2024 13:22

Contributor Author

brunozoric commented May 3, 2024

/cypress

brunozoric marked this pull request as ready for review

May 3, 2024 07:09

github-actions bot commented May 3, 2024

Cypress E2E tests have been initiated (for more information, click here). ✨


          fix(app-admin): div cannot be inside p tag

b5557ec

Pavel910 approved these changes

View reviewed changes

brunozoric merged commit 1d1b872 into next

91 checks passed

leopuleo deleted the bruno/feat/upgrade-to-react-18 branch

June 5, 2024 07:10

leopuleo restored the bruno/feat/upgrade-to-react-18 branch

June 5, 2024 07:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment