Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated Code #4051

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Remove Deprecated Code #4051

merged 2 commits into from
Mar 21, 2024

Conversation

adrians5j
Copy link
Member

@adrians5j adrians5j commented Mar 19, 2024

Changes

This PR removes deprecated code.

More specifically, we're removing:

  1. old lifecycle hooks
  2. old context.cms.permissions property, which was replaced by the new accessControl
  3. old api-admin-users-cognito-so-ddb and api-admin-users-cognito packages

How Has This Been Tested?

Relying on existing tests.

Documentation

We'll have these deprecations noted in our release docs.

@adrians5j adrians5j added this to the 5.40.0 milestone Mar 21, 2024
@adrians5j adrians5j marked this pull request as ready for review March 21, 2024 08:24
Copy link
Collaborator

@Pavel910 Pavel910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Love PRs of this kind! 0 additions :D

@adrians5j adrians5j merged commit ce96374 into next Mar 21, 2024
85 checks passed
@adrians5j adrians5j deleted the adrian/remove-deprecated-code branch April 5, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants