Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-aco): verify existence of identity while emptying the trash bins #4101

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

leopuleo
Copy link
Contributor

Changes

When FLP is enabled, we were encountering the error below while trying to list the entries to be deleted:

Error: Cannot read properties of undefined (reading 'type')

We were not defining any identity when emptying the trash bin.

In the same PR, we corrected the context type name from HeadlessCmsTasksContext to HcmsTasksContext in the test files.

Testing

This has been tested manually.

Documentation

None available.

@leopuleo leopuleo added the aco label Apr 29, 2024
@leopuleo leopuleo added this to the 5.40.0 milestone Apr 29, 2024
@leopuleo leopuleo self-assigned this Apr 29, 2024
Copy link
Member

@adrians5j adrians5j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick refactor, but LGTM.

packages/api-aco/src/utils/FolderLevelPermissions.ts Outdated Show resolved Hide resolved
@leopuleo leopuleo merged commit cdc9bea into next Apr 30, 2024
90 checks passed
@leopuleo leopuleo deleted the leo/fix/hcms-delete-background-task branch June 5, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants