File Manager: fix delete files action (not working in Page Builder) #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #637
In the File Manager, we used
useConfirmationDialoghook, which only works if the dialog plugin (packages/app-admin/src/plugins/Dialog/index.js) was registered in the current layout, which isn't the case for Page Builder. Because of this, using this hook won't work.Your solution
I replaced
useConfirmationDialoghook with a regularConfirmationDialogcomponent. Not only this fixes the reported issue, but it also makes the File Manager more modular because you don't have to think about the dialog plugin that needs to be registered in the layout. The solution will ensure the dialog is always shown.How Has This Been Tested?
Manual testing.
Screenshots (if relevant):
N/A