Allow Webix to be used from Meteor packages #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 19, 2015
mkozhukh
added a commit
that referenced
this pull request
Mar 10, 2015
Allow Webix to be used from Meteor packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a Webix package for Meteor that properly wraps it up and solves the load order issues.
The only change that was necessary was the removal of this
if(!window.webix) webix = {};statement. It seems redundant at line 18,643, since it's already present at the very beginning of the file. In my tests, Webix functions perfectly with this new change.PS: I've added you as a collaborator to the meteor-webix repo.