[OpenSSL] Treat types as opaque

[donny-dont]

309956d

[OpenSSL] Treat types as opaque
https://bugs.webkit.org/show_bug.cgi?id=239858

Reviewed by Basuke Suzuki.

LibreSSL 3.5.x made a number of types opaque for compatibility with OpenSSL. Unfortunately
a number of places in the WebCrypto implementation were accessing these structs directly.
Modify the code to use the provided functions to access and modify the types in the same
manner they were being used.

Modified WebCore::convertToBigNumber to return a BIGNUMPtr with a newly allocated BIGNUM.
This change was done because all calls to the function were returning a new BIGNUM rather
than reusing one after transitioning to opaque types. By returning a BIGNUMPtr leaks are
prevented. In the case where OpenSSL expects ownership to be transferred release() is
used.

* Source/WebCore/crypto/openssl/CryptoAlgorithmECDSAOpenSSL.cpp:
* Source/WebCore/crypto/openssl/CryptoKeyECOpenSSL.cpp:
* Source/WebCore/crypto/openssl/CryptoKeyRSAOpenSSL.cpp:
* Source/WebCore/crypto/openssl/OpenSSLUtilities.cpp:
* Source/WebCore/crypto/openssl/OpenSSLUtilities.h:

Canonical link: https://commits.webkit.org/251252@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[basuke]

Looks good to me, but how are the tests covered? Jitsu mentioned about the regression on bugzilla.

[donny-dont]

@basuke yea we fixed that. There was a wrong call to one of the getters.

[basuke]

LGTM 👍

[webkit-early-warning-system]

Committed r295168 (251252@main): https://commits.webkit.org/251252@main

Reviewed commits have been landed. Closing PR #1023 and removing active labels.