Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPE] Implement click counting in mouse events #15555

Merged
merged 1 commit into from Jul 6, 2023

Conversation

dpino
Copy link
Contributor

@dpino dpino commented Jul 5, 2023

@dpino dpino requested review from a team, donny-dont and zdobersek as code owners July 5, 2023 05:03
@dpino dpino requested a review from carlosgcampos July 5, 2023 13:24
@dpino dpino self-assigned this Jul 6, 2023
Source/WebKit/Shared/libwpe/WebEventFactory.cpp Outdated Show resolved Hide resolved
Source/WebKit/Shared/libwpe/WebEventFactory.cpp Outdated Show resolved Hide resolved
@dpino dpino added the merge-queue Applied to send a pull request to merge-queue label Jul 6, 2023
https://bugs.webkit.org/show_bug.cgi?id=174674

Reviewed by Carlos Garcia Campos.

Follow WinCairo logic to implement click counts for mouse events.

* LayoutTests/platform/wpe/TestExpectations:
* Source/WebKit/Shared/libwpe/WebEventFactory.cpp:
(WebKit::getDoubleClickTime):
(WebKit::clickCount):
(WebKit::WebEventFactory::createWebMouseEvent):

Canonical link: https://commits.webkit.org/265808@main
@webkit-commit-queue
Copy link
Collaborator

Committed 265808@main (0482f39): https://commits.webkit.org/265808@main

Reviewed commits have been landed. Closing PR #15555 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0482f39 into WebKit:main Jul 6, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 6, 2023
@dpino dpino deleted the fix/bug-174674 branch December 14, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants