[WebIDL] Cache extended attributes of WebIDL file #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a mechanism to invalidate the cache when the IDL changes? |
dpino
force-pushed
the
impr/cache-extended-atttributes
branch
from
147c7e0
to
4b2c602
Compare
I implemented the same mechanism used by |
webkit-early-warning-system
added
the
merging-blocked
dpino
force-pushed
the
impr/cache-extended-atttributes
branch
from
4b2c602
to
229e31a
Compare
dpino
force-pushed
the
impr/cache-extended-atttributes
branch
from
229e31a
to
1f8c9e3
Compare
No. But it’s an in-memory cache during the runtime of the script, not an on-disk cache. |
https://bugs.webkit.org/show_bug.cgi?id=241960 Reviewed by Darin Adler. * Source/WebCore/bindings/scripts/CodeGenerator.pm: (GetInterfaceExtendedAttributesFromName): Store results into a cache indexeded by IDL filename, so we don't need to parse the same file again. (ComputeIsCallbackInterface): Use slurp function to read file contents. (ComputeIsCallbackFunction): Use slurp function to read file contents. Canonical link: https://commits.webkit.org/255617@main
webkit-early-warning-system
force-pushed
the
impr/cache-extended-atttributes
branch
from
1f8c9e3
to
c7da26f
Compare
|
Committed 255617@main (c7da26f): https://commits.webkit.org/255617@main Reviewed commits have been landed. Closing PR #1769 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
yury-s
pushed a commit
to yury-s/WebKit
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c7da26f
https://github.com/False/commit/1f8c9e398af4817d65e6acf3a146a8015a4ee85c