Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCC] Fix build for Debian Stable after 270351@main #20220

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[GCC] Fix build for Debian Stable after 270351@main #20220

merged 1 commit into from
Nov 10, 2023

Conversation

dpino
Copy link
Contributor

@dpino dpino commented Nov 9, 2023 •
edited by webkit-early-warning-system
Loading

32983fe

[GCC] Fix build for Debian Stable after 270351@main
https://bugs.webkit.org/show_bug.cgi?id=264299

Reviewed by Yusuke Suzuki.

Wrap memcpy function call into local function to work around build
error.

* Source/JavaScriptCore/assembler/X86Assembler.h:
(JSC::X86Assembler::memcpyWrapper):
(JSC::X86Assembler::replaceWithNops):

Canonical link: https://commits.webkit.org/270526@main

9ccc61a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@dpino dpino requested a review from a team as a code owner November 9, 2023 09:34
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 9, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 33a3228)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Nov 9, 2023
Constellation
Constellation approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit.

@dpino dpino force-pushed the fix-build/debian11-after-270351@main branch from 33a3228 to 9ccc61a Compare November 10, 2023 10:49
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 10, 2023 •
edited
Loading

EWS run on current version of this PR (hash 9ccc61a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@dpino dpino added the merge-queue Applied to send a pull request to merge-queue label Nov 10, 2023
@dpino
[GCC] Fix build for Debian Stable after 270351@main
32983fe 
https://bugs.webkit.org/show_bug.cgi?id=264299

Reviewed by Yusuke Suzuki.

Wrap memcpy function call into local function to work around build
error.

* Source/JavaScriptCore/assembler/X86Assembler.h:
(JSC::X86Assembler::memcpyWrapper):
(JSC::X86Assembler::replaceWithNops):

Canonical link: https://commits.webkit.org/270526@main
@webkit-commit-queue
Copy link
Collaborator

Committed 270526@main (32983fe): https://commits.webkit.org/270526@main

Reviewed commits have been landed. Closing PR #20220 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 32983fe into WebKit:main Nov 10, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 10, 2023
@dpino dpino deleted the fix-build/debian11-after-270351@main branch December 14, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

Assignees

@dpino dpino

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
5 participants
@dpino @webkit-early-warning-system @webkit-commit-queue @Constellation @Ahmad-S792