Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPE] Unreviewed, build fix with LibWebRTC after 274358@main #24206

Merged
merged 1 commit into from
Feb 10, 2024
Merged

[WPE] Unreviewed, build fix with LibWebRTC after 274358@main #24206

merged 1 commit into from
Feb 10, 2024

Conversation

dpino
Copy link
Contributor

@dpino dpino commented Feb 10, 2024 •
edited by webkit-early-warning-system
Loading

e790e23

[WPE] Unreviewed, build fix with LibWebRTC after 274358@main
https://bugs.webkit.org/show_bug.cgi?id=268753

Guard functions only available for PLATFORM(COCOA).

* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.h:

Canonical link: https://commits.webkit.org/274423@main

5f15086

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@dpino dpino requested a review from cdumez as a code owner February 10, 2024 17:35
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 10, 2024 •
edited
Loading

EWS run on previous version of this PR (hash ca849d4)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🛠 gtk
  🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@dpino dpino changed the title Unreviewed, build fix for WPE with LibWebRTC after 274358@main [WPE] Unreviewed, build fix with LibWebRTC after 274358@main Feb 10, 2024
@dpino dpino force-pushed the fix-build/wpe-with-libwebrtc-after-274358@main branch from ca849d4 to 5f15086 Compare February 10, 2024 17:37
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 10, 2024 •
edited
Loading

EWS run on current version of this PR (hash 5f15086)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@dpino dpino added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 10, 2024
@dpino
[WPE] Unreviewed, build fix with LibWebRTC after 274358@main
e790e23 
https://bugs.webkit.org/show_bug.cgi?id=268753

Guard functions only available for PLATFORM(COCOA).

* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
* Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.h:

Canonical link: https://commits.webkit.org/274423@main
@webkit-commit-queue webkit-commit-queue force-pushed the fix-build/wpe-with-libwebrtc-after-274358@main branch from 5f15086 to e790e23 Compare February 10, 2024 19:20
@webkit-commit-queue
Copy link
Collaborator

Committed 274423@main (e790e23): https://commits.webkit.org/274423@main

Reviewed commits have been landed. Closing PR #24206 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e790e23 into WebKit:main Feb 10, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 10, 2024
@dpino dpino self-assigned this Feb 12, 2024
@dpino dpino deleted the fix-build/wpe-with-libwebrtc-after-274358@main branch May 7, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@dpino dpino

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dpino @webkit-early-warning-system @webkit-commit-queue