Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to group translation changes in fewer commits #16

Closed
jepler opened this issue Mar 23, 2012 · 2 comments
Closed

A way to group translation changes in fewer commits #16

jepler opened this issue Mar 23, 2012 · 2 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@jepler
Copy link

jepler commented Mar 23, 2012

I wish it was possible for weblate to create fewer commits than one per msgstr change.

Our 9-year old project has about 11000 commits. Our ".pot" file currently has 2647 messages. That means that fully translating just 5 languages with weblate will create more commits than the entire rest of the project! (even more, since weblate will be creating commits on 'maint' and 'master' branches and then we'll double the length of the history when merging 'maint' into master!)

I don't know what the implementation would be like, but for example all changes by the same author without a pause longer than 15 minutes could be placed in a single commit.

@nijel
Copy link
Member

nijel commented Mar 23, 2012

I've though quite a lot about this and it's quite tricky. With current approach, it is really simple to merge translations back and you don't have to care about anything. With some sort of merging things could get more complicated (once merging of commits would involve rewriting git history).

My current idea to handle this is to postpone committing changes as long as possible. This way Git history won't get rewritten (what would avoid troubles when merging changes).

So basically it would be like:

  • on translation done it would be stored to file
  • the commit will happen later once
    • somebody else works on the translation
    • merge from upstream occurs
    • optionally some timeout, though upstream merge will probably happen often enough

With current Weblate infrastructure this is quite easy to implement and would reduce number of commits lot. Though this would not be 100% merging of all contributions from single translator, what would be really hard to achieve.

@nijel
Copy link
Member

nijel commented Mar 27, 2012

Implemented in Git as outlined above.

@nijel nijel closed this as completed Mar 27, 2012
@ghost ghost assigned nijel Jul 12, 2012
WofWca referenced this issue in WofWca/weblate May 2, 2022
TD-875: Use user namespace to determine if acl check is required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants