Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node.js] Tests for cos, sin, tan can't meet the tolerance requirement #143

Open
mingmingtasd opened this issue Sep 28, 2021 · 1 comment
Assignees

Comments

@mingmingtasd
Copy link
Collaborator

Based on dml backend, running npm run test-ops through node.js under webnn-native/node will get results as below:

test element-wise unary operations
    √ abs
    √ ceil
a(-0.3924400508403778) b(-0.39242464) delta(0.00001541084037781637)
    59) cos
    √ exp
    √ floor
    √ log
    √ neg
a(0.9874919056892395) b(0.98748258) delta(0.000009325689239503276)
    60) sin
a(6.260713577270508) b(6.26066374) delta(0.00004983727050777986)
    61) tan
@mingmingtasd mingmingtasd self-assigned this Sep 28, 2021
@mingmingtasd mingmingtasd changed the title [Node.js] Tests for cos, neg, sin doesn't meet the tolerance requirement [Node.js] Tests for cos, sin, tan doesn't meet the tolerance requirement Sep 28, 2021
@mingmingtasd
Copy link
Collaborator Author

The result can't meet the criterion in webnn-polyfill tests:

export const opFp32AccuracyCriteria =
    new AccuracyCriterion(1e-6, 5.0 * 1.1920928955078125e-7);

In webnn-native end2end tests, criterion (fabs(output - expected) < 0.005f) can let tests pass.
@BruceDai @huningxin

@mingmingtasd mingmingtasd changed the title [Node.js] Tests for cos, sin, tan doesn't meet the tolerance requirement [Node.js] Tests for cos, sin, tan can't meet the tolerance requirement Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant