Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify which view/reshape like function are expected to copy #137

Closed
anssiko opened this issue Feb 4, 2021 · 2 comments
Closed

Clarify which view/reshape like function are expected to copy #137

anssiko opened this issue Feb 4, 2021 · 2 comments
Labels
tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response.

Comments

@anssiko
Copy link
Member

anssiko commented Feb 4, 2021

  1. I see quite a few view/reshape like functions, which of these are expected to copy and which are not? Probably good to note this in the spec.

via w3ctag/design-reviews#570 (comment)

To be clarified in the spec, possible implementation details.
@anssiko anssiko added the tag label Feb 4, 2021
@anssiko anssiko mentioned this issue Feb 4, 2021
Closed
1 task
@dontcallmedom dontcallmedom added tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response. and removed tag labels Feb 12, 2021
@wchao1115 wchao1115 mentioned this issue Feb 15, 2021
Merged
@w3cbot w3cbot mentioned this issue Feb 15, 2021
Open
@cynthia
Copy link

cynthia commented Feb 21, 2021

https://github.com/webmachinelearning/webnn/pull/144/files/44870dee0271e50ead69da93bf4ef0b9c206537e

Looking at this PR, wouldn't it make sense to define a common term for logical tensor changes (e.g. views?) somewhere early in the document so that concept can be re-used?

@anssiko anssiko mentioned this issue Mar 8, 2021
Closed
@anssiko
Copy link
Member Author

anssiko commented Mar 8, 2021

Addressed by #144, but see also #150.

@cynthia, I filed #150 to give your comment its own tag-tracker issue. Helps surface this in the tracker better.

@anssiko anssiko closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tag-tracker Group bringing to attention of the TAG, or tracked by the TAG but not needing response.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cynthia @dontcallmedom @anssiko