Content: Clarify the expected behavior for axes being empty #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shape calculation for argMin/argMax and reduction ops is now
fully specified, but the implied behavior of {axes:[]} for these
ops and layerNormalization was not particularly clear.
Add a little text to make it clearer.
Fixes webmachinelearning#493
|
@BruceDai can you take an initial look? |
|
I apologize for my late response. LGTM, thanks for these clarification texts. |
|
Thanks @BruceDai - and no worries. I'm generating a lot of review requests. @fdwr and @huningxin - please review/merge at your leisure! |
huningxin
approved these changes
Mar 14, 2024
github-actions bot
added a commit
that referenced
this pull request
Mar 14, 2024
SHA: 048e855 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shape calculation for argMin/argMax and reduction ops is now fully specified, but the implied behavior of {axes:[]} for these ops and layerNormalization was not particularly clear.
Add a little text to make it clearer.
Fixes #493
Preview | Diff