Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting the session will cause 500 error over store-api #56

Closed
Isengo1989 opened this issue Aug 25, 2021 · 2 comments
Closed

Setting the session will cause 500 error over store-api #56

Isengo1989 opened this issue Aug 25, 2021 · 2 comments

Comments

@Isengo1989
Copy link

https://github.com/webmatch/WbmTagManagerEcomm/blame/f530a244089536de7a58726ebdd0de6bfd0d2a72/src/Subscriber/KernelEventsSubscriber.php#L66

will cause a 500 error when getting the context from the store-api - there should be a return or other way to get the session

if (empty($session)){
return;
}
@wbm-sbasler
Copy link
Collaborator

Can you please stick to the pinned issue #16 when reporting a bug. Especially the steps to reproduce!

@wbm-sbasler
Copy link
Collaborator

I guess it's fixed in v2.1.6, so I'll close this ticket now.

Please let me now if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Isengo1989 @wbm-sbasler