Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File manager (filemin) does not honor pagination values #2108

Open
Mecha-Weasel opened this issue Mar 26, 2024 · 26 comments
Open

File manager (filemin) does not honor pagination values #2108

Mecha-Weasel opened this issue Mar 26, 2024 · 26 comments

Comments

@Mecha-Weasel
Copy link

Environment:

  • New installation of LMDE (Linux Mint Debian Edition) basically Mint built on Debian 12.x repos, etc.
  • Running as VM under VMware Player 17.
  • Fresh install of Webmin, installed via the setup-repos process (from here https://webmin.com/download/)
  • Webmin, version: 2.105
  • Authentic theme, version: 21.09.5

How to recreate:

  • Open webmin URL.
  • Login.
  • Open File Manager under Tools category.
  • Select settings (gear) icon, in top-right corner.
  • Set Default number of items per page option as desired, selecting from drop-down list (say 500).
  • Set Maximum number of items in directory without using server pagination option as desired, selecting from drop-down list (say 1000).
  • Clock Save button to return to File Manager interface.

Expected results:

  • File Manager pane should allow a long list (500 items) with vertical scroll-bar as needed.

Actual results:

  • File Manager pane is still limiting the list of items to either what fits without scrolling, or even less - forcing multiple "pages".

Some examples:

  • Viewing /, and showing 14 of 25 items, and making it 2 pages.
  • Viewing /etc,, and only showing 14 of 156 items, and making it 12 pages.

Notes:

  • I check the /etc/webmin/filemin folder to see if the preferences were getting populated.
  • The "per_page=500" option is being populated in the user's perfs.userid file.
  • The "config_portable_module_filemanager_records_for_server_pagination=1000" option is being populated in the user's perfs.userid file.
@iliajie
Copy link
Collaborator

iliajie commented Mar 26, 2024

Hello,

Thanks for reaching out!

Here's what I tried based on your report (Debian 12) and the result I got:

file-manager-large-pagination.mp4

Aside from everything, I would strongly advise against displaying 500 files on the page. It will make user experience horrible with everything laggy and slow. You don't need to do it. If you need to find a file, just start typing, and it will filter results you're looking for in no time.

@Mecha-Weasel
Copy link
Author

Still not working for me. Doesn't matter what I set the options tool, seems to do what it feels like.
Also I do not have an "automatic" option in my File Manager options page.

@Mecha-Weasel
Copy link
Author

PS: to be more specific about OS environment, I am running LMDE (Linux Mint Debian Edition, https://linuxmint.com/download_lmde.php) which Webmin is detecting as "Debian 12".

@iliajie
Copy link
Collaborator

iliajie commented Apr 7, 2024

Still not working for me. Doesn't matter what I set the options tool, seems to do what it feels like.
Also I do not have an "automatic" option in my File Manager options page.

Which browser are you using? Did you try another browser, Chromium for example, or incognito tab with all browser extensions disabled?

@Mecha-Weasel
Copy link
Author

Mecha-Weasel commented Apr 7, 2024

yeah made no difference. but if I switch from Authentic Theme to Framed Theme, the pagination issue goes away - but of course File Manager looks completely different too.

With Authentic Theme:
image

With Framed Theme:
image

@iliajie
Copy link
Collaborator

iliajie commented Apr 7, 2024

What kind of Webmin user is that? Is this safe Webmin user? What is set on File Manager ACL page (Webmin Users) exactly?

@Mecha-Weasel
Copy link
Author

Here's what is set for that user:

image

@iliajie
Copy link
Collaborator

iliajie commented Apr 9, 2024

I cannot reproduce this issue, it works just fine for me!

Though, I have a question - what is the output of the following command on your server:

find /etc -name *gamer-servers*

@Mecha-Weasel
Copy link
Author

I'm sorry. Don't mean to be a pain, just don't understand why this happens. I do appreciate the attempts.

here's that output:

root@ExampleVPS-2024b-Live:~# find /etc -name *game-servers;
/etc/webmin/shell/previous.game-servers
/etc/webmin/filemin/prefs.game-servers
/etc/webmin/custom/prefs.game-servers

@iliajie
Copy link
Collaborator

iliajie commented Apr 9, 2024

I'm sorry. Don't mean to be a pain, just don't understand why this happens.

No problem. I'm willing to help.

/etc/webmin/filemin/prefs.game-servers

What is the content of /etc/webmin/filemin/prefs.game-servers file?

@Mecha-Weasel
Copy link
Author

Mecha-Weasel commented Apr 9, 2024

BTW: This doesn't happen just for that game-servers account, if I login to Webmin as root, the pagination issue is there too.

Here are the contents of that file:

config_portable_module_filemanager_remember_tabs=false
config_portable_module_filemanager_show_dot_files=true
config_portable_module_filemanager_hide_tree_view=false
config_portable_module_filemanager_hide_actions=true
config_portable_module_filemanager_calculate_size=true
config_portable_module_filemanager_tree_expand_search=true
config_portable_module_filemanager_hide_toolbar=false
config_portable_module_filemanager_view_limit=512000
per_page=500
config_portable_module_filemanager_hovered_toolbar=false
config_portable_module_filemanager_files_safe_mode=true
config_portable_module_filemanager_checksum_limit=1024000
config_portable_module_filemanager_tree_view_depth=3
columns=type,size,owner_user,permissions,last_mod_time
config_portable_module_filemanager_editor_maximized=false
config_portable_module_filemanager_editor_detect_encoding=true
config_portable_module_filemanager_switch_users=true
config_portable_module_filemanager_move_to_trash=false
config_portable_module_filemanager_default_sort=0
config_portable_module_filemanager_records_for_server_pagination=1000
config_portable_module_filemanager_force_tar=true
config_portable_module_filemanager_tree_exclude_on_first_load=true
config_portable_module_filemanager_editor_tabs_to_spaces=false

@iliajie
Copy link
Collaborator

iliajie commented Apr 9, 2024

Can you also run then the following and see what you get:

grep -Rsi per_page /etc /root

@Mecha-Weasel
Copy link
Author

PS: Correction to my previous statement about OS version. The VMware Player VM this is on is running Debian 12.5, it was the host is running LMDE.

@Mecha-Weasel
Copy link
Author

Here's the output ...

root@ExampleVPS-2024b-Live:~# grep -Rsi per_page /etc /root
/etc/webmin/filemin/prefs.game-servers:per_page=500
/etc/webmin/filemin/prefs.root:per_page=500
/etc/webmin/authentic-theme/settings-game-servers.js:config_portable_module_filemanager_auto_per_page=true;
/etc/webmin/authentic-theme/settings-game-servers.js:config_portable_module_filemanager_records_per_page='500';
/etc/webmin/authentic-theme/settings-root.js:config_portable_module_filemanager_records_per_page='20';
/etc/webmin/authentic-theme/settings-root.js:config_portable_module_filemanager_auto_per_page=true;

@iliajie
Copy link
Collaborator

iliajie commented Apr 9, 2024

/etc/webmin/authentic-theme/settings-root.js:config_portable_module_filemanager_records_per_page='20';
/etc/webmin/authentic-theme/settings-root.js:config_portable_module_filemanager_auto_per_page=true;

These settings are supposed to be changing on saving File Manager configuration page. Try debugging it in your browser or just manually change (i.e. 20 has to be 500 and true goes to false) those settings and reload the page.

@Mecha-Weasel
Copy link
Author

ok that fixed it (for root):

image

@iliajie
Copy link
Collaborator

iliajie commented Apr 9, 2024

Ah, I see — you're in the Cloudflare! I wish I knew this before, as they are blocking stuff!

@Mecha-Weasel
Copy link
Author

config_portable_module_filemanager_auto_per_page

Cloudflare? no, I am not. This is just a VMware Player VM running Debian, that happens to be on a LMDE desktop host. Its all just on the LAN here at home.

@Mecha-Weasel
Copy link
Author

Works for the game-servers account too (after making that change to config_portable_module_filemanager_auto_per_page for game-servers also):

image

@iliajie
Copy link
Collaborator

iliajie commented Apr 9, 2024

You should fix your fonts!

@Mecha-Weasel
Copy link
Author

Is the config_portable_module_filemanager_auto_per_page option implemented in the theme?

@iliajie
Copy link
Collaborator

iliajie commented Apr 9, 2024

Is the config_portable_module_filemanager_auto_per_page option implemented in the theme?

Yes, it is.

@Mecha-Weasel
Copy link
Author

You should fix your fonts!

Looks okay live on this end but on the preview here looks bad, but I think thats just scaling the image.

@Mecha-Weasel
Copy link
Author

Wondering if some bug in the theme then? or some other one-time issue that messed-up my configs? Anyway, thanks so much for the help!

@iliajie
Copy link
Collaborator

iliajie commented Apr 9, 2024

Are you running this instance with Cloudflare?

@Mecha-Weasel
Copy link
Author

Are you running this instance with Cloudflare?

No. Literally a VMware Player VM running on a desktop computer at home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants