Add tests to make sure readme and methods stay up to date #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BackEndTea
commented
Jun 28, 2018
| */ | ||
| public function testHasNullOr($method) | ||
| { | ||
| if ($method === 'notNull' || $method === 'null') { |
There was a problem hiding this comment.
Technically we do offer nullOr for these two methods, but they make absolutely no sense, so i chose to not add them to the list
(No really when do you check for nullOrNotNull or nullOrNull?)
|
cc @keradus |
|
love to see my idea spreading 👍 |
|
This is absolutely awesome! |
|
Thank you @Nyholm |
|
it took a while ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some new tests that make sure all the methods have a corresponding
nullOrandallin the list of@methodat the top of the class. It also makes sure that new methods are in the readme.Plus it also fixes the errors found by these tests.