You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webnative.app() has been replaced by webnative.program(). Which is now the sole entry point of webnative (no more initialise or permissionedApp either). The reason for the rename is to avoid confusion with Webnative apps, the ones you create via the CLI or dashboard.
authed WAT session variable has been replaced by session. A Webnative program will only give you a session if you're authenticated. I didn't want two variables representing roughly the same state so I removed authed
You can only add Uint8Arrays to the filesystem. That means that strings, files and blobs all have to be converted to Uint8Arrays first. I added one util function for that and strings are converted with TextEncoder/TextDecoder (or use the uint8arrays library).
I replaced the base64 data URIs in the gallery with object urls pointing to Blobs for performance. I assume that's why the file size was set to max 5MB? I increased it to 20 since it's much faster now.
I created a program store because this is the main interaction point to do something with your program. As opposed to using the webnative global. For example, before you'd call webnative.auth.isUsernameValid(), now you'd use program.auth.isUsernameValid(). Reasoning here is that global state has been removed from webnative, so all state lives in your created Program. I'm not entirely sure creating a store was the right approach here, since I'm not familiar with Svelte. Let me know if there's a better way to do this.
I made some adjustments to the type checking code in the gallery. Still not ideal, but safer.
Let me know if anything else needs explaining or if you have ideas to further improve any of the API.
Remaining issues:
After linking another device, it still shows the non-authenticated view on the consumer. Refreshing the page fixes it, but it takes a few seconds.
Linking does not always work? Webnative issue? Needs more testing.
webnative.app() has been replaced by webnative.program()
Why is this necessary? Is it just because the signature of the method has changed, or is there a semantic reason why "program" is better than "app". TBH I think "app" is more generically understandable by developers.
webnative.app() has been replaced by webnative.program()
Why is this necessary? Is it just because the signature of the method has changed, or is there a semantic reason why "program" is better than "app". TBH I think "app" is more generically understandable by developers.
That came out of discussion with Boris who found the usage of app in this context confusing (correct me if I'm wrong Boris). I more or less agree. We have the app platform code as well in webnative to create Fission apps. I think we want to look at app cloning too in the future (at least we discussed that in the past). Meaning, we could have a tighter integration with apps. So to avoid confusion between the two concepts I opted for program. This also fits better technically since you can create multiple programs that represent the same app.
@avivash@bgins I figured out what the linking issue is, the linking producer is sometimes created multiple times. Not sure why it happens though, something something subscription to session store?
It happens whenever I am redirect to the "delegate-account" page (eg. by clicking connect-device button) If I'm already on that page and refresh, it works as intended.
Also happens on main branch, see console log at https://webnative-template.fission.app/
ahh interesting! I'll try to recreate/debug it 👀
So it seems the page is double mounted exclusively when it is the slot of the SidebarNav component. Not quite sure why yet, but it's a starting point 🤔
@avivash@bgins I figured out what the linking issue is, the linking producer is sometimes created multiple times. Not sure why it happens though, something something subscription to session store?
It happens whenever I am redirect to the "delegate-account" page (eg. by clicking connect-device button) If I'm already on that page and refresh, it works as intended.
Also happens on main branch, see console log at https://webnative-template.fission.app/
ahh interesting! I'll try to recreate/debug it 👀
So it seems the page is double mounted exclusively when it is the slot of the SidebarNav component. Not quite sure why yet, but it's a starting point 🤔
@icidasset i've got a fix 👍🏼, will push it shortly
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to to Webnative
v0.35.Changes:
webnative.app()has been replaced bywebnative.program(). Which is now the sole entry point of webnative (no moreinitialiseorpermissionedAppeither). The reason for the rename is to avoid confusion with Webnative apps, the ones you create via the CLI or dashboard.authedWAT session variable has been replaced bysession. A Webnative program will only give you a session if you're authenticated. I didn't want two variables representing roughly the same state so I removedauthedUint8Arrays to the filesystem. That means that strings, files and blobs all have to be converted to Uint8Arrays first. I added one util function for that and strings are converted with TextEncoder/TextDecoder (or use the uint8arrays library).I created a program store because this is the main interaction point to do something with your program. As opposed to using the webnative global. For example, before you'd callwebnative.auth.isUsernameValid(), now you'd useprogram.auth.isUsernameValid(). Reasoning here is that global state has been removed from webnative, so all state lives in your createdProgram. I'm not entirely sure creating a store was the right approach here, since I'm not familiar with Svelte. Let me know if there's a better way to do this.Let me know if anything else needs explaining or if you have ideas to further improve any of the API.
Remaining issues: