Avivash/add loading UI #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les/webnative-app-template into avivash/add-loading-ui
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
icidasset
reviewed
Nov 18, 2022
Deploying with
|
| Latest commit: |
ce78553
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://779d1f09.webnative-template.pages.dev |
| Branch Preview URL: | https://avivash-add-loading-ui.webnative-template.pages.dev |
|
@icidasset i think this is good to go now if you're happy with it 👍🏼 I applied the same change to the WAT-react PR |
avivash
commented
Nov 18, 2022
| @@ -9,7 +10,7 @@ export const initialize = async (): Promise<void> => { | |||
|
|
|||
| const program: webnative.Program = await webnative.program({ | |||
| tag: { creator: 'Fission', name: 'WAT' }, | |||
| debug: false // TODO: Add a flag or script to turn debugging on/off | |||
| debug: dev | |||
There was a problem hiding this comment.
Also, added this to automatically toggle debug on in dev mode 👍🏼
bgins
approved these changes
Nov 19, 2022
icidasset
added a commit
that referenced
this pull request
Jan 5, 2023
* Upgrade to webnative 0.35 * Linking * Adjust loadAccount * Chore: update avatar size limit to be 20mb - also update gallery size limit error message * Chore: move program.auth.webCrypto to sessionStore.authStrategy (#93) * program.id → program.tag * Use AuthenticationStrategy type * Single auth strategy * Fix: always pass program.auth to sessionStore * Avivash/add loading UI (#94) * tag -> namespace * Avivash/51 private file info (#95) * Fix: delegate route being mounted twice * Fix: orange and gradient directions * Fix: footer gradient direction * Bump webnative * Use alpha version * Upgrade alpha version * Bump alpha release * Bump * Avivash/UI updates (#102) * Bump Co-authored-by: avivash <av@andrewvivash.com> Co-authored-by: Andrew Vivash <andy@fission.codes> Co-authored-by: Brian Ginsburg <gins@brianginsburg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the loading spinner from other webnative templates into this one
Type of change
Screenshots/Screencaps
Authed:
https://www.loom.com/share/6c14c862eea0411993ed464505e4dd35
Not Authed:
https://www.loom.com/share/2d144eeb03f54cd186a83fe779704792