Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests on fresh install #60

Open
NikolaGavric94 opened this issue Jun 7, 2018 · 1 comment
Open

Failing tests on fresh install #60

NikolaGavric94 opened this issue Jun 7, 2018 · 1 comment

Comments

@NikolaGavric94
Copy link

On fresh package install after running install.sh there is a lot of core tests failing due to wrong indendation/spaces. Also there is an issue when starting tests from operating system other than Linux because of wget which is not pre-installed on OSX or Win. And also not able to run clean.sh from outside lumen-test folder.

Expected Behavior

All the core tests should pass.

After running install.sh, codecept.phar should exist inside lumen-test.

Being able to run clean.sh outside of lumen-test folder.

Current Behavior

Not all core tests pass.

After running install.sh I get an error wget command not found.

After running clean.sh outside of lumen-test folder I get a bunch of 'File doesn't exist' issues.

Possible Solution

Remove all indentation inside stubs to avoid tests failing.

Install either with curl or wget.

Do all operations inside clean.sh relative to it's parent and not current dir.

Steps to Reproduce

# Command Error
1. git clone _repo
2. sh install.sh wget command not found
3. sh test.sh A bunch of errors in core tests
4. cd lumen-test
5. sh clean.sh api/routes not found

Context (Environment)

Testing env - Trying to fix the failing core tests and optimize the shell scripts a bit.

Detailed Description

/

Possible Implementation

I will do a pull request to fix the above issues

NikolaGavric94 added a commit to NikolaGavric94/webneat-lumen-generators that referenced this issue Jun 7, 2018
@NikolaGavric94
Copy link
Author

This should also fix #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant