Logo in README Not Best For GitHub Dark Theme

[zicklag]

Hey there, I just noticed that the logo doesn't look quite right on the GitHub dark theme.

Not sure what the best path forward is, but jus thought I'd let you know in case you don't notice it because you're on the light theme.

Neat looking project BTW! 👍

[haixuanTao]

Thanks! Yeah, ahah, I did it really quickly, I should probably do another header.

Thanks for the issue :)

[pixelspark]

Hi,

I tweaked the logo a bit (a square 'avatar' for the org as well as a logo with slogan that works a bit better on black backgrounds). Inkscape SVG attached. If you like it I will update the logos. Should use SVG's anyway of course.

[haixuanTao]

I'm all in to have svgs but the formating of the SVG you put looks weird on my laptop. I'm, on Firefox.

[pixelspark]

I'm all in to have svgs but the formating of the SVG you put looks weird on my laptop. I'm, on Firefox.

Looks like the SVG references the font I used. I assumed Inkscape would convert that to paths. Attached are new versions, these don't require the font (the characters are now paths in the SVG). Hopefully these render correctly.

[haixuanTao]

This looks much better.

I think it would be perfect if it could render well in dark mode as well.

But if you don't want to bother feel free to update the settings and commit the new logo.

[pixelspark]

This looks much better.

I think it would be perfect if it could render well in dark mode as well.

But if you don't want to bother feel free to update the settings and commit the new logo.

I specifically added the white outline so it looks a little better than the old logo,but I agree it is not yet optimal.

With some SVG tricks you could probably make it dynamic (if the browser supports the CSS 'prefers-color-scheme' mechanism? Not sure how wide-spread/compatible that is).

[pixelspark]

Here's one that should automatically switch to white text when dark mode is enabled!

[haixuanTao]

The dark version is perfect and the light version seems great when I click on the SVG. But when it is within a comment the SVG looks weird, not sure why.

I think that you can try to put it in the README and preview how it render.

[pixelspark]

Yes, there's something funny going on with caching I suspect. Will commit this image to the repo later today (I already updated the org's logo and social image).

[zicklag]

I'm not sure if GitHub might like sanitize the SVG to prevent it from utilizing the browser CSS rules?

Anyway, even with the white outline it's far better than it was before. 👍