Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for image_map and config sample generator #15

Closed
BennyThink opened this issue Mar 2, 2020 · 4 comments
Closed

Support for image_map and config sample generator #15

BennyThink opened this issue Mar 2, 2020 · 4 comments
Assignees
Labels
discussion This topic needs some discussion. enhancement New feature or request

Comments

@BennyThink
Copy link
Member

image map: support multiple IMG_PATH
config sample dump: add cli param to generate a sample config. @n0vad3v Which param should we choose? Didn't find a good one.

@BennyThink BennyThink added the enhancement New feature or request label Mar 2, 2020
@n0vad3v
Copy link
Member

n0vad3v commented Mar 2, 2020

For the sample config, I'm in support of resilio sync, which is ./rslsync --dump-sample-config > sync.conf, we can do the same.

Speaking of image map, actually this might introduce the complexity of managing routes and static files. Maybe we should implement a better way for users to run multiple webp-server instances to face their need?

@BennyThink
Copy link
Member Author

Okay, let's call it --dump-sample-config, just print the config.
And the second one,
More than one instance is easy, but it requires to configure systemd again, and probably consume more RAM than one instance. Image map is one-click, I guess we'll need some more test and careful design

@BennyThink BennyThink added the discussion This topic needs some discussion. label Mar 2, 2020
@BennyThink
Copy link
Member Author

sample generator/systemd generator is done. Image map needs more design

@BennyThink
Copy link
Member Author

I think this issue should be closed. Image_MAP may decrease the performance since it has to lookup in different dir. Better use different instance instead.

@BennyThink BennyThink linked a pull request Mar 12, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This topic needs some discussion. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants