Skip to content
This repository has been archived by the owner on Oct 27, 2020. It is now read-only.

feat: add options validation (schema-utils) #24

Merged
merged 1 commit into from
Nov 17, 2017
Merged

feat: add options validation (schema-utils) #24

merged 1 commit into from
Nov 17, 2017

Conversation

michael-ciniawsky
Copy link
Member

Notable Changes

  • adds options validation via schema-utils

cacheloadervalidationerror

@michael-ciniawsky michael-ciniawsky added this to the 1.1.0 milestone Nov 15, 2017
@codecov
Copy link

codecov bot commented Nov 15, 2017 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (next@f63cbff). Click here to learn what that means.
The diff coverage is 91.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next      #24   +/-   ##
=======================================
  Coverage        ?   17.47%           
=======================================
  Files           ?        2           
  Lines           ?      103           
  Branches        ?       13           
=======================================
  Hits            ?       18           
  Misses          ?       73           
  Partials        ?       12
Impacted Files Coverage Δ
src/index.js 17.64% <91.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f63cbff...826fcf7. Read the comment docs.

@joshwiens joshwiens changed the base branch from master to next November 16, 2017 11:55
@joshwiens joshwiens modified the milestones: 1.2.0, 2.0.0 Nov 16, 2017
@michael-ciniawsky michael-ciniawsky mentioned this pull request Nov 16, 2017
Closed
alexander-akait
alexander-akait approved these changes Nov 17, 2017
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@joshwiens joshwiens changed the base branch from next to master November 17, 2017 14:33
@joshwiens joshwiens modified the milestones: 2.0.0, 1.2.0 Nov 17, 2017
@joshwiens
Copy link
Member

@michael-ciniawsky - Targeted master as discussed

@joshwiens joshwiens merged commit 4ac7807 into master Nov 17, 2017
@joshwiens joshwiens deleted the feat/validation branch November 17, 2017 14:34
@michael-ciniawsky michael-ciniawsky removed this from the 1.3.0 milestone Feb 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@joshwiens joshwiens joshwiens approved these changes

Assignees
No one assigned
Labels
semver: Minor status: Approved type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michael-ciniawsky @joshwiens @alexander-akait