Fix coffee-script dependency version #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jacobthemyth Please close and reopen the PR to trigger the CLA Bot again. Thx in advance 😛 |
michael-ciniawsky
requested changes
Mar 10, 2017
package.json
Outdated
| @@ -1,13 +1,13 @@ | |||
| { | |||
| "name": "coffee-loader", | |||
| "version": "0.7.2", | |||
| "version": "0.7.3", | |||
There was a problem hiding this comment.
Please don't 😛 npm version and release will be always done by us.
coffee-loader uses `v3SourceMap`, which was introduced in `coffee-script@1.6.0`, so this makes that dependency explicit.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coffee-loaderusesv3SourceMap, which was introduced incoffee-script@1.6.0, so this makes that dependency explicit. This was broken in projects that already had a dependency oncoffee-script >1.0 <= 1.6.0, since that met the peer dependency, yet threw errors on compile.