Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add transpile option (options.transpile) #47

Merged
merged 4 commits into from
Oct 5, 2017
Merged

feat: add transpile option (options.transpile) #47

merged 4 commits into from
Oct 5, 2017

Conversation

vladflip
Copy link
Contributor

Added transpile option.
http://coffeescript.org/#transpilation

@jsf-clabot
Copy link

jsf-clabot commented Sep 25, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@michael-ciniawsky michael-ciniawsky changed the title Transpile option feat: add transpile option (options.transpile) Sep 25, 2017
michael-ciniawsky
michael-ciniawsky reviewed Sep 25, 2017
View reviewed changes
README.md
@@ -56,6 +56,7 @@ module.exports = {
|:--:|:-----:|:----------|
|**`literate`**|`false`|Enable CoffeeScript in Markdown (Code Blocks) e.g `file.coffee.md`|
|**`sourceMap`**|`false`|Enable/Disable Sourcemaps|
|**`transpile`**|`false`|Provide Babel presets and plugins|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coffeescript uses babel under the hood by default or are other transpilers possible in theory ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there is a built in support only for Babel as I see.

README.md Outdated
@@ -99,6 +100,31 @@ module.exports = {
}
```

### [Transpile](http://coffeescript.org/#transpilation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do my a favour and wrap all headings in backticks please ? 😛 \### [Transpile]() => \### [`Transpile`]()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

@michael-ciniawsky michael-ciniawsky added this to the v0.8.0 milestone Sep 25, 2017
michael-ciniawsky
michael-ciniawsky approved these changes Sep 25, 2017
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladflip Thx

@michael-ciniawsky
Copy link
Member

@vladflip Does this feature have any version restrictions e.g coffeescript >= v2.0.0 etc ? We need to check and eventually guard it then, in case it fails for older versions of CoffeeScript

@vladflip
Copy link
Contributor Author

@michael-ciniawsky It's a new feature yes, just checked with older coffee-script, works fine.

alexander-akait
alexander-akait reviewed Sep 26, 2017
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be good add tests, but no tests in this repo 😞

@vladflip
Copy link
Contributor Author

@evilebottnawi I don't see any tests in this repo

@michael-ciniawsky michael-ciniawsky mentioned this pull request Sep 29, 2017
Closed
@joshwiens joshwiens merged commit abaf498 into webpack-contrib:master Oct 5, 2017
@jamesruan
Copy link

hope to see in release quickly
some of my package fail to run because of the lacking of this option

@vladflip
Copy link
Contributor Author

@jamesruan its already there

@umeboshi2
Copy link

@vladflip It's in the repo, but not quite released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

@joshwiens joshwiens joshwiens approved these changes

Assignees
No one assigned
Labels
semver: Minor status: Approved type: Feature
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vladflip @jsf-clabot @michael-ciniawsky @jamesruan @umeboshi2 @alexander-akait @joshwiens