Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security patch for version 5 fixing serialize-javascript npm audit #520

Closed
yashha opened this issue Aug 24, 2020 · 6 comments
Closed

Security patch for version 5 fixing serialize-javascript npm audit #520

yashha opened this issue Aug 24, 2020 · 6 comments

Comments

@yashha
Copy link

yashha commented Aug 24, 2020

  • Operating System:
  • Node Version:
  • NPM Version:
  • webpack Version:
  • copy-webpack-plugin Version: 5.1.1

Feature Proposal

Provide a security dependency patch for version 5 to fix the serialize-javascript issue.
e.g. 5.1.2

Just an idea, if you want that vue-cli do upgrade to version 6 then the fix in in vue-cli will take probably longer.

Feature Use Case

vuejs/vue-cli#5789
vuejs/vue-cli#5782

@yashha yashha changed the title Security path for version 5 Security patch for version 5 Aug 24, 2020
@yashha yashha changed the title Security patch for version 5 Security patch for version 5 fixing serialize-javascript npm audit Aug 24, 2020
@alexander-akait
Copy link
Member

Why do not update copy-webpack-plugin?

@yashha
Copy link
Author

yashha commented Aug 24, 2020

I don't know, it was just an idea, because there are some breaking changes, it is maybe not an easy upgrade.
The CI failed when submitting the pr. vuejs/vue-cli#5782
We can close it and wait for an update in vue-cli when you want. I did go now for a npm-force-resolutions solution for now.

@BryceV
Copy link

BryceV commented Aug 24, 2020

I am in a similar spot. Trying to find out if we can jump from 5.1.1 to the latest semver to remove this security warning. Is the update across versions seamless?

@alexander-akait
Copy link
Member

@BryceV you need to read changelog, there are many breaking changes

@yashha
Copy link
Author

yashha commented Aug 27, 2020

Also a good idea:
@sodatea created a fork "copy-webpack-plugin-v5": "5.1.2"
vuejs/vue-cli#5829

We can close this issue then I guess. It is not as clean than having a small security release for version 5 of "copy-webpack-plugin" though.

@yashha
Copy link
Author

yashha commented Aug 28, 2020

Update with release v5.1.2, thanks @evilebottnawi!

@yashha yashha closed this as completed Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants