Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't output invalid es5 code when locals do not exists #1035

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1033

Breaking Changes

No

Additional Info

@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #1035 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
+ Coverage   99.15%   99.15%   +<.01%     
==========================================
  Files          10       10              
  Lines         475      476       +1     
  Branches      145      146       +1     
==========================================
+ Hits          471      472       +1     
  Misses          4        4
Impacted Files Coverage Δ
src/utils.js 98.96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95a779...3631082. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css-loader produces invalid es5 code
1 participant