-
-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code needs linting + new contributors #251
Comments
I poked Tobias about this. Hopefully we get you on board. 👍 I agree a linting standard would be great (easier PRs, development). #124 is probably the highest priority item. After 0.14x css-loader lost a significant chunk of performance. This was due to the inclusion of postcss based processing and CSS Modules supoprt if I remember correctly. Perhaps the best way to fix that would be to revert back to 0.14 state, apply possible fixes on top of that where possible, and encourage people to use CSS Modules through postcss (postcss-loader). It's a special case after all. |
@mgcrea Any update? As far as I understand, Tobias should have contacted you by now. 😄 |
👍 for creating a webpack eslint |
@mgcrea |
I just checked out the code and it's a mess! Mixed spaces and tabs, etc. You should have a standard eslint file for every projects under the
webpack
namespace. Usually, airbnb styleguide is a good start. You could extend it in a new projecteslint-config-webpack
and apply that strictly to all projects.I know you must have more on your plate right now. I'll gladly help if you want. With 94 pending issues and 7 PRs, I think it's time to add new collaborators.
The text was updated successfully, but these errors were encountered: