Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code needs linting + new contributors #251

Closed
mgcrea opened this issue Apr 2, 2016 · 6 comments
Closed

Code needs linting + new contributors #251

mgcrea opened this issue Apr 2, 2016 · 6 comments

Comments

@mgcrea
Copy link

mgcrea commented Apr 2, 2016

I just checked out the code and it's a mess! Mixed spaces and tabs, etc. You should have a standard eslint file for every projects under the webpack namespace. Usually, airbnb styleguide is a good start. You could extend it in a new project eslint-config-webpack and apply that strictly to all projects.

I know you must have more on your plate right now. I'll gladly help if you want. With 94 pending issues and 7 PRs, I think it's time to add new collaborators.

@mgcrea mgcrea changed the title Please add new contributors Code needs linting + new contributors Apr 2, 2016
@bebraw
Copy link
Contributor

bebraw commented Apr 9, 2016

I poked Tobias about this. Hopefully we get you on board. 👍

I agree a linting standard would be great (easier PRs, development). #124 is probably the highest priority item. After 0.14x css-loader lost a significant chunk of performance. This was due to the inclusion of postcss based processing and CSS Modules supoprt if I remember correctly.

Perhaps the best way to fix that would be to revert back to 0.14 state, apply possible fixes on top of that where possible, and encourage people to use CSS Modules through postcss (postcss-loader). It's a special case after all.

@bebraw
Copy link
Contributor

bebraw commented Apr 23, 2016

@mgcrea Any update? As far as I understand, Tobias should have contacted you by now. 😄

@mgcrea
Copy link
Author

mgcrea commented Apr 23, 2016

@bebraw Indeed, I've been added as a contributor for the webpack CSS related projects, but I have been pretty busy lately. #124 does not look like an easy fix, will try to dig a little bit deeper in the coming days/weeks. Hope I'll be able to help.

@bebraw
Copy link
Contributor

bebraw commented Apr 23, 2016

@mgcrea Ok, cool. #124 seems active so that's good!

@jhnns
Copy link
Member

jhnns commented Apr 29, 2016

👍 for creating a webpack eslint
👍 for keeping the css-loader simple. I think, @sokra justed wanted to add some features and ended up with CSS modules – which is cool, but many projects just want the css-loader to resolve urls and translate it into CommonJS. It's not fair to put the performance overhead on those :)

@michael-ciniawsky
Copy link
Member

@mgcrea v1.0.0 will have all of that 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants