fix(rules): update remaining v2 syntax

Author: joshwiens

rules/best-practices.js

@@ -293,7 +293,7 @@ module.exports = {
 
     // require using Error objects as Promise rejection reasons
     // http://eslint.org/docs/rules/prefer-promise-reject-errors
-    'prefer-promise-reject-errors': ['on', { allowEmptyReject: true }],
+    'prefer-promise-reject-errors': ['error', { allowEmptyReject: true }],
 
     // enforce the consistent use of the radix argument when using parseInt()
     // http://eslint.org/docs/rules/radix

rules/es2015.js

@@ -119,7 +119,7 @@ module.exports = {
 
     // require destructuring from arrays and/or objects
     // http://eslint.org/docs/rules/prefer-destructuring
-    'prefer-destructuring': ['on', {
+    'prefer-destructuring': ['error', {
       array: true,
       object: true,
     }, {

rules/imports.js

@@ -121,7 +121,7 @@ module.exports = {
 
     // disallow namespace imports
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-namespace.md
-    'import/no-namespace': 'on',
+    'import/no-namespace': 'error',
 
     // Ensure consistent use of file extension within the import path
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md
@@ -132,7 +132,7 @@ module.exports = {
 
     // Enforce a convention in module import order
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md
-    'import/order': ['on', {
+    'import/order': ['error', {
       groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
       'newlines-between': 'never',
     }],

rules/stylistic-issues.js

@@ -77,7 +77,7 @@ module.exports = {
 
     // enforce the consistent use of either function declarations or expressions
     // http://eslint.org/docs/rules/func-style
-    'func-style': ['on', 'expression'],
+    'func-style': ['error', 'expression'],
 
     // disallow specified identifiers
     // http://eslint.org/docs/rules/id-blacklist
@@ -129,7 +129,7 @@ module.exports = {
 
     // enforce position of line comments
     // http://eslint.org/docs/rules/line-comment-position
-    'line-comment-position': ['on', {
+    'line-comment-position': ['error', {
       position: 'above',
       ignorePattern: '',
       applyDefaultPatterns: true,
@@ -190,7 +190,7 @@ module.exports = {
 
     // enforce newlines between operands of ternary expressions
     // http://eslint.org/docs/rules/multiline-ternary
-    'multiline-ternary': ['on', 'never'],
+    'multiline-ternary': ['error', 'never'],
 
     // require constructor names to begin with a capital letter
     // http://eslint.org/docs/rules/new-cap

rules/variables.js

@@ -38,7 +38,7 @@ module.exports = {
 
     // disallow the use of undefined as an identifier
     // http://eslint.org/docs/rules/no-undefined
-    'no-undefined': 'on',
+    'no-undefined': 'error',
 
     // disallow unused variables
     // http://eslint.org/docs/rules/no-unused-vars