LOOKING FOR A MAINTAINER

[ThomasKientz]

From previous maintainer :

Please please please, #webpack community, please take control on eslint-loader. Nobody is maintaining it. I do whatever I can because I don’t like to let things rot… but I am about to let it rot (I don’t use eslint-loader for months…) and will ignore its notifications soon.

https://twitter.com/MoOx/status/1044577532815855616

[MoOx]

@ThomasKientz stop acting like a consumer. You can maintain this package just by asking.

[ThomasKientz]

@MoOx I would love to but I have never maintained one before ! Please add me, I will see what can I do.

[MoOx]

Sadly I don’t have the right to add contributors since the package is under webpack .org.
Can @TheLarkInn or @ooflorent help us?
After that I could answer to your technical questions around the workflow to fix and release if necessary.

[alexander-akait]

@MoOx i can help with permissions and rights

[alexander-akait]

@ThomasKientz I can give you rights, except npm, we need to work with you for a while to avoid something illegal. I would also like to ask you how much time you can spend? Sometimes developers say what they will be maintain repo, but don't do this.

[ThomasKientz]

@evilebottnawi I would guess between 1 to 5 hours a week. But I am not sure that this repo needs this amount of time, right now (from what I understand) it needs to merge one pull request to fix an issue affecting a relatively large amont of people. To be clear I have never maintained an open source repo before but I would love to start contributing. I have 3 years of experience in web dev.

@MoOx Would be very nice !

[alexander-akait]

@ThomasKientz 👍
@MoOx ping me again (just make sure everything is right) and i will add rights to @ThomasKientz

[MoOx]

Lgtm. Will review code change before giving npm rights.

[alexander-akait]

@ThomasKientz invite was sent

[ThomasKientz]

@evilebottnawi thanks ! Will look into this tomorrow ;)

[MoOx]

Feel free to continue discussion here if you need anything.

[ThomasKientz]

@MoOx Can I merge #262 directly or do I need to do something first ?

[MoOx]

@ThomasKientz if the fix seems ok, and proven by tests this time, you need to

• merge the pr
• bump this to 2.1.2

  eslint-loader/package.json

  Line 3 in f9d48ea

  "version": "2.1.1",

• edit https://github.com/webpack-contrib/eslint-loader/blob/master/CHANGELOG.md accordingly with a new section
• push commits
• ask for npm rights
• do the appropriate npm add-user https://docs.npmjs.com/cli/adduser
• then run npm run release

  eslint-loader/package.json

  Line 46 in f9d48ea

  "release": "npmpub"

This last step, thanks to npmpub, will create a tag with the version specified in the package.json, push it on github, publish on npm, and create a release on github with the changelog section you added previously.

[ThomasKientz]

@MoOx #262 seems ok and passed all tests.

But there is a review #262 (review). What is the best practice if I want to modify the pull request accordingly and avoid changes in readme.md ? Do I create a new commit by my side by copying only the desired changes (here : index.js) (thus spoiling credits of the author) ?

Whom do I ask the npm rights ?

[MoOx]

@ThomasKientz it's good to have additional tests, especially when it come to a bugfix (to ensure it's actually doing something).

For this comment, I guess that's seems to be a normal change from prettier (via pretty-quick) so you can safely merge it this time.

You can ask me npm rights as soon as you are ready to publish (I will just take a look to master, assuming you are going to publish master without any weird trick - to avoid this kind of problem
https://blog.npmjs.org/post/180565383195/details-about-the-event-stream-incident)

[ThomasKientz]

@MoOx Ready to push to npm ! 02c1e76

[MoOx]

@ThomasKientz What is your npm login?

[ThomasKientz]

@MoOx blaydator

[MoOx]

@ThomasKientz You have been invited.

[MoOx]

Reopening as it seems that this package is clearly not maintained at this time.

[ricardogobbosouza]

@MoOx i can help with this.
This package does not need a lot of time, but attention when needed

[MoOx]

@evilebottnawi can you help us to add @ricardogobbosouza ?

[alexander-akait]

Yes

@ricardogobbosouza for releases ping me

[ricardogobbosouza]

@evilebottnawi
I think we can release,
At least to have support for eslint 6

[alexander-akait]

@ricardogobbosouza in todo, release will be tomorrow