Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression #83

Closed
jsg2021 opened this issue Feb 11, 2021 · 3 comments · Fixed by #95
Closed

Performance regression #83

jsg2021 opened this issue Feb 11, 2021 · 3 comments · Fixed by #95

Comments

@jsg2021
Copy link
Contributor

jsg2021 commented Feb 11, 2021

By moving the finishModule hook we no longer spread the linting work out... one lump (in my case 5620 files) gets sent to the linter in one go. The thread pool (if threaded) does not fill up... only one worker gets all the jobs.

Originally posted by @jsg2021 in #73 (comment)
@watjurk watjurk mentioned this issue Feb 12, 2021
Closed
6 tasks
@ricardogobbosouza
Copy link
Collaborator

Resolved on v2.5.1

@jsg2021
Copy link
Contributor Author

jsg2021 commented Feb 12, 2021

I'm afraid this doesn't solve the performance regression. By dispatching a single lint(files); at the end we negate the thread pool's parallelization. The call to lint(files) is dispatched to a single worker... lint needs to be called as modules are found so that it can be run in parallel with the build.

@jsg2021
Copy link
Contributor Author

jsg2021 commented Feb 12, 2021

Maybe we can lump all the files at the end if we aren't threaded?

@jsg2021 jsg2021 mentioned this issue Feb 19, 2021
Open
@ricardogobbosouza ricardogobbosouza mentioned this issue Apr 4, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use finishModules if thread is less than or equal 1 webpack-contrib/eslint-webpack-plugin
2 participants
@jsg2021 @ricardogobbosouza