feat: allow '*' wild card for tag option #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| list: [ | ||
| { | ||
| // Tag name | ||
| tag: '*', // or tag: '' |
There was a problem hiding this comment.
No need to support tag: '*', if you don't provide tag try to use on all attributes, i.e tag can be string or undefined (not specify)
There was a problem hiding this comment.
It will work now when the string is empty or it's undefined
src/options.json
Outdated
| @@ -5,8 +5,7 @@ | |||
| "type": "object", | |||
| "properties": { | |||
| "tag": { | |||
| "type": "string", | |||
| "minLength": 1 | |||
| "type": "string" | |||
There was a problem hiding this comment.
Need to return it to minLength to 1
src/plugins/source-plugin.js
Outdated
| // eslint-disable-next-line no-undefined | ||
| element.tag === undefined || | ||
| // eslint-disable-next-line no-undefined | ||
| (element.tag !== undefined && !element.tag.length)) && |
There was a problem hiding this comment.
I think we can simplify it
test/attributes-option.test.js
Outdated
| attributes: { | ||
| list: [ | ||
| { | ||
| tag: '', |
There was a problem hiding this comment.
Should throw a validation error
test/attributes-option.test.js
Outdated
| } catch (e) { | ||
| expect(e.message.search('ValidationError')).not.toEqual(-1); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Move it to validation.test.js
src/plugins/source-plugin.js
Outdated
| // eslint-disable-next-line no-undefined | ||
| (element.tag === undefined || | ||
| // eslint-disable-next-line no-undefined | ||
| (element.tag !== undefined && |
There was a problem hiding this comment.
Use type of value === "undefined" to avoid disable the rule
alexander-akait
approved these changes
Mar 31, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
solve : #267
Breaking Changes
No
Additional Info