Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update less dependency to 2.x #22

Closed
nullobject opened this issue Nov 13, 2014 · 9 comments
Closed

Update less dependency to 2.x #22

nullobject opened this issue Nov 13, 2014 · 9 comments

Comments

@nullobject
Copy link

The current dependency is ^1.5.

@nullobject nullobject changed the title Update less dependency to 2.x. Update less dependency to 2.x Nov 13, 2014
@jhnns
Copy link
Member

jhnns commented Nov 18, 2014

Just wanted to leave a note that the less-loader currently doesn't run with less 2.x as they have changed something internally. Needs further investigation.

@nullobject
Copy link
Author

Sure, I’m quite happy to investigate this 😀

On 18 Nov 2014, at 10:13 pm, Johannes Ewald notifications@github.com wrote:

Just wanted to leave a note that the less-loader currently doesn't run with less 2.x as they have changed something internally. Needs further investigation.


Reply to this email directly or view it on GitHub.

@jhnns
Copy link
Member

jhnns commented Nov 19, 2014

Go ahead! We appreciate every contribution (and the source code is fairly easy to understand) 👍

@jhnns
Copy link
Member

jhnns commented Nov 25, 2014

It seems like the less-loader needs a thorough rewrite. Less 2.0 provides a plugin mechanism which should be used by the less-loader instead. We can use the less-plugin-npm-import as blueprint.

@DimitryDushkin
Copy link

+1 )

@timkung
Copy link

timkung commented Dec 2, 2014

+1 :)

@snapwich
Copy link

+1, I think using the plugin support will fix the issues I've been having.

Currently I'm using the gulp-less plugin in my build alongside gulp-webpack + less-loader for some other stuff. Both have a dependency on less and they do not play well together at all. I think it's actually less-loader overwriting the less.Parser.fileLoader that is breaking things, but haven't dug far enough into it to find out.

@sokra sokra closed this as completed Dec 22, 2014
@jeffscottward
Copy link

why was this closed? the less-loader has yet to be rewritten.

@jhnns
Copy link
Member

jhnns commented Dec 25, 2014

less 2.0 support has been shipped with #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants