fix: avoid to throw error when link doesn't have parentNode #1016
Conversation
|
|
src/index.js
Outdated
| @@ -862,7 +862,7 @@ class MiniCssExtractPlugin { | |||
| 'err.code = "CSS_CHUNK_LOAD_FAILED";', | |||
| "err.type = errorType;", | |||
| "err.request = realHref;", | |||
| "linkTag.parentNode.removeChild(linkTag)", | |||
| "if(linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)", | |||
There was a problem hiding this comment.
Please add space after if
There was a problem hiding this comment.
@alexander-akait I fixed it. Please review again~
|
I have pushed a commit to fix test case errors. Please approve again! Thx. |
VieZhong
requested review from
snitin315 and
alexander-akait
and removed request for
snitin315 and
alexander-akait
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1016 +/- ##
=======================================
Coverage 90.37% 90.37%
=======================================
Files 5 5
Lines 831 831
Branches 222 222
=======================================
Hits 751 751
Misses 70 70
Partials 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
OLD API tests are failing, can you check? |
I missed testing the old API. And Now I fixed it. Please review the code again. |
VieZhong
requested review from
alexander-akait and
snitin315
and removed request for
snitin315 and
alexander-akait
|
Do you have the access to merge? Please merge and plubish a new version. Thank you all. |
|
Thank you |
This PR contains a:
Motivation / Use-Case
The variable
iis a Link tag. But when it loads error, it's parentNode is null. So it will throw an error.Here is the fix , just like what Alexander does in hmr.
Breaking Changes
Additional Info
see this issuse: #1017