Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't invalidate cache after timeout refresh #1023

Merged
merged 2 commits into from Mar 16, 2023

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Mar 16, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Very hard to tests due we need to found a timeframe when it was created when it was refreshed and checkrf on rebuild late

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.10 ⚠️

Comparison is base (3a3cb51) 90.37% compared to head (049bc2f) 90.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
- Coverage   90.37%   90.27%   -0.10%     
==========================================
  Files           5        5              
  Lines         831      833       +2     
  Branches      222      224       +2     
==========================================
+ Hits          751      752       +1     
- Misses         70       71       +1     
  Partials       10       10              
Impacted Files Coverage Δ
src/index.js 96.09% <75.00%> (-0.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit 38d8513 into master Mar 16, 2023
30 of 32 checks passed
@alexander-akait alexander-akait deleted the fix-restore-cache-after-renew branch March 16, 2023 23:54
@7rulnik 7rulnik mentioned this pull request Mar 17, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant